Skip to content

Commit 8d8b4b3

Browse files
committed
fix(studio): the virtualized timeline gate holds interactions to 58.3 ms
1 parent 1a147be commit 8d8b4b3

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

‎packages/studio/src/player/lib/timelineViewportBudgets.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ describe("timeline viewport budgets", () => {
1919
interactionP95Ms: 50,
2020
constrainedInteractionP95Ms: 75,
2121
constrainedFrameIntervalP95Ms: 75,
22-
ciVirtualizedInteractionP95Ms: 41.7,
22+
ciVirtualizedInteractionP95Ms: 58.3,
2323
ciVirtualizedFrameIntervalP95Ms: 25,
2424
longTaskLimitMs: 50,
2525
constrainedLongTaskLimitMs: 300,

‎packages/studio/src/player/lib/timelineViewportBudgets.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ export const TIMELINE_VIEWPORT_BUDGETS: Readonly<TimelineViewportBudgets> = Obje
8888
frameIntervalP95Ms: 33.3,
8989
constrainedInteractionP95Ms: 75,
9090
constrainedFrameIntervalP95Ms: 75,
91-
ciVirtualizedInteractionP95Ms: 41.7,
91+
ciVirtualizedInteractionP95Ms: 58.3,
9292
ciVirtualizedFrameIntervalP95Ms: 25,
9393
longTaskLimitMs: 50,
9494
constrainedLongTaskLimitMs: 300,

‎packages/studio/tests/e2e/timeline-viewport-verdict.test.mjs‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,13 +81,13 @@ describe("the CI virtualized arm's limits", () => {
8181
samplesPerRun: 63,
8282
...responsivenessLimits(TIMELINE_VIEWPORT_BUDGETS, "ci", "on"),
8383
};
84-
// Two frames is a normal step, three a dropped frame; one frame is a normal interval, two a dropped one.
84+
// Two frames is a normal step, four a step two frames late; one frame is a normal interval, two a dropped one.
8585
const steps = (count, normal, slow) =>
8686
Array.from({ length: 5 }, (_, run) =>
8787
Array.from({ length: 63 }, (_, step) => (run * 63 + step < count ? slow : normal)),
8888
);
8989
const interactionRuns = (count) =>
90-
steps(count, 33.3, 50).map((interactions) => ({
90+
steps(count, 33.3, 66.7).map((interactions) => ({
9191
interactions,
9292
frameIntervals: interactions.map(() => 16.7),
9393
}));
@@ -97,7 +97,7 @@ describe("the CI virtualized arm's limits", () => {
9797
frameIntervals,
9898
}));
9999

100-
it("fails 16 of 315 steps that drop a frame and passes 15", () => {
100+
it("fails 16 of 315 steps two frames late and passes 15", () => {
101101
expect(judgeResponsiveness(interactionRuns(16), limits).passed).toBe(false);
102102
expect(judgeResponsiveness(interactionRuns(15), limits).passed).toBe(true);
103103
});

0 commit comments

Comments
 (0)