Skip to content

Commit 6f2fc62

Browse files
committed
ci: guard the edit-accuracy gate against a failed changes job
Studio: edit accuracy gate is a required status check on main, and it is the only gated required check without a needs.changes.result guard. If changes fails its outputs are unset, the condition is false, the job skips, and GitHub reports a skipped job as Success, so the required check passes with nothing run. Six sibling required checks already handle this: Build, Typecheck, Test, Test: runtime contract, Render on windows-latest and Tests on windows-latest all carry needs.changes.result != 'success'. This applies the same guard here. When changes succeeds the condition is unchanged, so there is no difference on the happy path.
1 parent 5c7f631 commit 6f2fc62

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

‎.github/workflows/ci.yml‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1100,7 +1100,9 @@ jobs:
11001100
studio-edit-accuracy-gate:
11011101
name: "Studio: edit accuracy gate"
11021102
needs: [changes, studio-edit-accuracy]
1103-
if: ${{ !cancelled() && github.event_name == 'pull_request' && needs.changes.outputs.edit_accuracy == 'true' }}
1103+
if: ${{ !cancelled() && github.event_name == 'pull_request'
1104+
&& (needs.changes.result != 'success'
1105+
|| needs.changes.outputs.edit_accuracy == 'true') }}
11041106
runs-on: ubuntu-latest
11051107
timeout-minutes: 5
11061108
permissions:

0 commit comments

Comments
 (0)