test(cli): windows orphan proof with creation-time guard

Author: miguel-heygen

.github/checkfast/winlaunch.sh

@@ -1,6 +1,11 @@
 set -u
 node --import tsx packages/cli/scripts/prepare-process-test-browser.mjs; export HYPERFRAMES_BROWSER_PATH=$(grep HYPERFRAMES_BROWSER_PATH "$GITHUB_ENV" | tail -1 | cut -d= -f2-)
 cd packages/cli
-for i in 1 2 3; do echo "=== ORPH run $i"; npx vitest run src/browser/chromeOrphans.process.test.ts --maxWorkers=1 2>&1 | sed 's/\x1b\[[0-9;]*m//g' | grep -E "✓|×|Tests |AssertionError|Error:|^\+ " ; done
+r() { npx vitest run src/browser/chromeOrphans.process.test.ts --maxWorkers=1 2>&1 | sed 's/\x1b\[[0-9;]*m//g' | grep -E "✓|×|Tests |AssertionError|^\+ "; }
+for i in 1 2 3; do echo "=== ORPH run $i"; r; done
+cp src/browser/windowsChromeWatchdog.ts /tmp/wd.ts
+sed -i 's/      HF_CHROME_SINCE: String(launchedAt),/      HF_CHROME_SINCE: String(launchedAt + 3_600_000),/' src/browser/windowsChromeWatchdog.ts
+echo "=== MUTANT start time in the future ($(grep -c '3_600_000' src/browser/windowsChromeWatchdog.ts))"; r
+cp /tmp/wd.ts src/browser/windowsChromeWatchdog.ts
 sed -i 's/  if (!executable || chrome.pid === undefined) return undefined;/  return undefined;/' src/browser/windowsChromeWatchdog.ts
-echo "=== MUTANT no watchdog ($(grep -c '^  return undefined;$' src/browser/windowsChromeWatchdog.ts))"; npx vitest run src/browser/chromeOrphans.process.test.ts --maxWorkers=1 2>&1 | sed 's/\x1b\[[0-9;]*m//g' | grep -E "✓|×|Tests |AssertionError|^\+ "
+echo "=== MUTANT no watchdog ($(grep -c '^  return undefined;$' src/browser/windowsChromeWatchdog.ts))"; r

packages/cli/src/browser/launch.ts

@@ -112,6 +112,7 @@ async function launchOwnedBrowser(
   ownSignals();
   const abort = new AbortController();
   const signal = options.signal ? AbortSignal.any([options.signal, abort.signal]) : abort.signal;
+  const launchedAt = Date.now();
   const launch = untilLaunchOrAbort(
     puppeteer.launch({ ...options, pipe: true, signal, handleSIGINT: false, handleSIGTERM: false }),
     signal,
@@ -130,7 +131,7 @@ async function launchOwnedBrowser(
     const child = browser.process();
     if (!child) throw new Error("A launched browser has no owned process.");
     browsers.add(browser);
-    const watchdog = watchChromeTree(child);
+    const watchdog = watchChromeTree(child, launchedAt);
     if (watchdog) watchdogs.set(browser, watchdog);
     child.once("exit", () => browsers.delete(browser));
     return browser;

packages/cli/src/browser/windowsChromeWatchdog.ts

@@ -1,7 +1,7 @@
 import { spawn, type ChildProcess } from "node:child_process";
 import { realpathSync } from "node:fs";
 
-const SWEEP = `$b=[int]$env:HF_CHROME_PID; $x=$env:HF_CHROME_EXE; Get-CimInstance Win32_Process | Where-Object { ($_.ProcessId -eq $b -or $_.ParentProcessId -eq $b) -and $_.ExecutablePath -eq $x } | ForEach-Object { Stop-Process -Id $_.ProcessId -Force -ErrorAction SilentlyContinue }`;
+const SWEEP = `$b=[int]$env:HF_CHROME_PID; $x=$env:HF_CHROME_EXE; $t=[DateTimeOffset]::FromUnixTimeMilliseconds([int64]$env:HF_CHROME_SINCE).UtcDateTime; Get-CimInstance Win32_Process | Where-Object { ($_.ProcessId -eq $b -or $_.ParentProcessId -eq $b) -and $_.ExecutablePath -eq $x -and $_.CreationDate.ToUniversalTime() -ge $t } | ForEach-Object { Stop-Process -Id $_.ProcessId -Force -ErrorAction SilentlyContinue }`;
 
 const WATCHDOG = `let clean = false;
 const done = () => {
@@ -25,12 +25,20 @@ function executableOf(chrome: ChildProcess): string | undefined {
 }
 
 /** Windows does not end a process's children with it, so Chrome's children outlive a killed CLI without this. */
-export function watchChromeTree(chrome: ChildProcess): ChromeWatchdog | undefined {
+export function watchChromeTree(
+  chrome: ChildProcess,
+  launchedAt: number,
+): ChromeWatchdog | undefined {
   const executable = process.platform === "win32" ? executableOf(chrome) : undefined;
   if (!executable || chrome.pid === undefined) return undefined;
   const watchdog = spawn(process.execPath, ["-e", WATCHDOG], {
     detached: true,
-    env: { ...process.env, HF_CHROME_PID: String(chrome.pid), HF_CHROME_EXE: executable },
+    env: {
+      ...process.env,
+      HF_CHROME_PID: String(chrome.pid),
+      HF_CHROME_EXE: executable,
+      HF_CHROME_SINCE: String(launchedAt),
+    },
     stdio: ["pipe", "ignore", "ignore"],
     windowsHide: true,
   });