fix(engine): audio scratch files Windows refuses to delete no longer fail a render

Author: miguel-heygen

packages/engine/src/index.ts

@@ -396,6 +396,7 @@ export {
 
 export { trackChildProcess, killTrackedProcesses } from "./utils/processTracker.js";
 export { renameWithRetry, renameWithRetryAsync } from "./utils/renameWithRetry.js";
+export { removeScratch } from "./utils/removeScratch.js";
 
 // drawElement self-verify comparison — shared by the streaming drain
 // (producer) and the parallel disk-path verify (parallelCoordinator).

packages/engine/src/services/aacEncode.ts

@@ -4,7 +4,8 @@
  */
 
 import { execFile } from "node:child_process";
-import { mkdtempSync, readFileSync, rmSync, writeFileSync } from "node:fs";
+import { mkdtempSync, readFileSync, writeFileSync } from "node:fs";
+import { removeScratch } from "../utils/removeScratch.js";
 import { dirname, join } from "node:path";
 import { getFfmpegBinary } from "../utils/ffmpegBinaries.js";
 import { runFfmpeg, type RunFfmpegResult } from "../utils/runFfmpeg.js";
@@ -166,6 +167,6 @@ export async function encodeAac(
     const slowest = Math.max(...results.map((result) => result.durationMs));
     return { ...muxed, durationMs: slowest + muxed.durationMs };
   } finally {
-    rmSync(dir, { recursive: true, force: true });
+    removeScratch(dir);
   }
 }

packages/engine/src/services/audioFxRender.ts

@@ -19,7 +19,6 @@ import {
   openSync,
   readFileSync,
   readSync,
-  rmSync,
   statSync,
   writeFileSync,
   writeSync,
@@ -30,6 +29,7 @@ import { pathToFileURL } from "node:url";
 import { getAudioFxRuntimeScript } from "@hyperframes/core/audio-fx-runtime";
 import { enabledAudioFxNodes, type HfAudioFxChain } from "@hyperframes/core/audio-fx";
 import { serializeAutomation, type HfAutomation } from "@hyperframes/core/audio-automation";
+import { removeScratch } from "../utils/removeScratch.js";
 import { acquireBrowser } from "./browserManager.js";
 import { createEnvelopeWalker } from "./audioVolumeEnvelope.js";
 import { riffChunks, wavFormatTag } from "./wavChunks.js";
@@ -630,7 +630,7 @@ async function withFxBrowser<T>(
       `Audio FX failed for track ${options.trackId}: ${(err as Error).message}`,
     );
   } finally {
-    rmSync(hostDir, { recursive: true, force: true });
+    removeScratch(hostDir);
     await lease?.release().catch(() => undefined);
   }
 }

packages/producer/src/services/render/audioPadTrim.ts

@@ -20,7 +20,7 @@
  */
 
 import { spawn } from "node:child_process";
-import { mkdtempSync, rmSync } from "node:fs";
+import { mkdtempSync } from "node:fs";
 import { dirname, join } from "node:path";
 import {
   DEFAULT_CONFIG,
@@ -29,6 +29,7 @@ import {
   extractAudioMetadata,
   getFfprobeBinary,
   ManagedChildProcess,
+  removeScratch,
   renameWithRetry,
   runFfmpeg,
   trackChildProcess,
@@ -333,7 +334,7 @@ export async function padOrTrimAudioToVideoFrameCount(
       }`,
     };
   } finally {
-    for (const path of plan.cleanupPaths) rmSync(path, { force: true });
+    for (const path of plan.cleanupPaths) removeScratch(path);
   }
 
   let loweredDb = 0;
@@ -479,7 +480,7 @@ async function enforceAacTruePeak(input: EnforceAacTruePeakInput): Promise<{
       )}`,
     };
   } finally {
-    if (scratchDir) rmSync(scratchDir, { recursive: true, force: true });
+    if (scratchDir) removeScratch(scratchDir);
   }
 }
 

packages/producer/src/services/render/stages/audioStage.ts

@@ -18,12 +18,12 @@
  */
 
 import { join } from "node:path";
-import { rmSync } from "node:fs";
 import type { Fps } from "@hyperframes/core";
 import {
   MIXED_AUDIO_FILENAME,
   audioFailureDiagnostics,
   processCompositionAudio,
+  removeScratch,
   type AudioProcessingFailure,
   type MixResult,
 } from "@hyperframes/engine";
@@ -111,7 +111,7 @@ export async function runAudioStage(input: AudioStageInput): Promise<AudioStageR
     }
     return { ...result, audioLoweredDb, audioProcessMs: Date.now() - stageStart };
   } finally {
-    rmSync(pcmSourcePath, { force: true });
+    removeScratch(pcmSourcePath);
   }
 }