fix(lint): the missing-audio check skips audio tags that scripts build as strings

Author: miguel-heygen

packages/lint/src/hevcPreviewLint.test.ts

@@ -40,6 +40,16 @@ describe("collectLocalVideoCandidates", () => {
     expect([...candidates.keys()]).toEqual([join(dir, "design/styleframes/clip.mp4")]);
   });
 
+  it("finds a double-quoted src whose name contains an apostrophe", () => {
+    const dir = makeProject(["assets/Ann's clip.mp4"]);
+
+    const candidates = collectLocalVideoCandidates(dir, [
+      { html: `<video src="assets/Ann's clip.mp4"></video>` },
+    ]);
+
+    expect([...candidates.keys()]).toEqual([join(dir, "assets/Ann's clip.mp4")]);
+  });
+
   it("still resolves project-root refs that have no sibling", () => {
     const dir = makeProject(["assets/clip.mp4"]);
 

packages/lint/src/project.test.ts

@@ -833,6 +833,14 @@ describe("a double-quoted src that contains an apostrophe", () => {
     expect(codes).toContain("audio_src_not_found");
   });
 
+  it("does not read an audio tag that an inline script builds as a string", async () => {
+    const codes = await lintCodes(
+      `<script>var s = '<audio src="' + u + '">'; var t = "<audio src='" + u + "'>";</script>`,
+      [],
+    );
+    expect(codes).not.toContain("audio_src_not_found");
+  });
+
   it("does not read a src out of another attribute's text", async () => {
     const codes = await lintCodes(`<img id="i1" alt="x src='ghost.png'" />`, []);
     expect(codes).not.toContain("missing_local_asset");

packages/lint/src/project.ts

@@ -370,8 +370,9 @@ function lintAudioSrcNotFound(
 
   const missingByFile = new Map<string, Set<string>>();
   for (const { html, compSrcPath } of htmlSources) {
+    const scannable = maskNonScannableRanges(html);
     let match: RegExpExecArray | null;
-    while ((match = audioSrcRe.exec(html)) !== null) {
+    while ((match = audioSrcRe.exec(scannable)) !== null) {
       const src = mediaSrcOf(match);
       if (/^(https?:|data:|blob:)/i.test(src)) continue;
       if (isUnresolvedAssetPlaceholder(src)) continue;