Repository navigation
Support for library charts #237
Description
Is this a request for help?:
Probably
Is this a BUG REPORT or FEATURE REQUEST? (choose one):
This is a FEATURE REQUEST. I would like to be able to test library charts to
some degree using the chart-testing automation.
This will help with maintaining library charts since it could make it easier to change them if they are properly tested.
Version of Helm and Kubernetes:
"latest"
What happened:
I created a library chart on a repo with the chart-testing GitHub Action enabled.
What you expected to happen:
That chart-testing does some sort or more or less meaningful tests on my library chart.
How to reproduce it (as minimally and precisely as possible):
Run the install tests of chart-testing against a charts/ folder containing a library chart.
Anything else we need to know:
I think there are a few reasonable ideas on how to tackle this but wanted to get some input:
- this could be out of scope for chart-testing and I should ignore my library. If this is the way to go I should try to always combine any changes to the library chart with changes to an example chart that uses the library (this might result in some sorts of dependency-hell when it comes to managing Chart.lock files in PRs)
- chart-testing could support a concrete example of the library in the
ci/folder and use that for testing - chart-testing could only support linting library charts and not exit with and simply not attempt to install a library chart (i can already do this by ignoring my library chart)
Activity
lukasz-mitka commentedon Jan 28, 2021
I would go with not event trying to install library charts. Since it's not possible just skip them.
For anyone looking for a workaround: Create separate config file for install only which excludes library charts.
gionn commentedon Feb 2, 2023
We have a library chart among other charts, it's quite surprising to see that libraries chart are not supported.
Before discovering this issue, I had also to create an empty
values.yamlotherwise was even failing earlier.Will try to use a separated config for
ct installbut looks really clunky.fix: work around chart-testing not supporting lib charts
fix: work around chart-testing not supporting lib charts
fix: work around chart-testing not supporting lib charts
github-actions commentedon Nov 29, 2023
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.
lukasz-mitka commentedon Nov 29, 2023
bad bot.
Still needed.
github-actions commentedon Dec 31, 2023
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.
hairmare commentedon Dec 31, 2023
most likely ct should just skip library charts during
ct install, but it should lint them duringct lint. I can do this now using two different configs, but keeping those up to date feels error prone and a lot of manual work.would a change that just makes
ct installskip library charts be a welcome change?davidkarlsen commentedon Dec 31, 2023
@hairmare I'd say that makes sense. Just skip them and print a warning.
cpanato commentedon Jan 19, 2024
+1 with tests :)
6 remaining items
lukasz-mitka commentedon Mar 21, 2024
No, sorry, no time to spare.
github-actions commentedon Apr 23, 2024
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.
lukasz-mitka commentedon Apr 23, 2024
bad bot
lukasz-mitka commentedon Apr 23, 2024
@cpanato Could you set an exempt-issue-labels for these kind of issues?
cpanato commentedon Apr 23, 2024
sounds good @lukasz-mitka
github-actions commentedon May 24, 2024
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.
lukasz-mitka commentedon May 24, 2024
bad bot!