TRCLI-266: Attachments not 'attached' to the test in the test run, for AutomationID (code first) tests#423
Open
acuanico-tr-galt wants to merge 2 commits into
Open
TRCLI-266: Attachments not 'attached' to the test in the test run, for AutomationID (code first) tests#423acuanico-tr-galt wants to merge 2 commits into
acuanico-tr-galt wants to merge 2 commits into
Conversation
…, also updated uploading attachments to use threadpool executor to parallelize and speed up uploading.
…achment processing and uploading logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being resolved: #421
Solution description
The as_completed() function returns futures in the order they complete, not in submission order, to resolve this we
store responses by request ID and reconstruct in original order.
Changes
Modified handle_futures() in api_request_handler.py to:
We also optimized attachments uploading to use Threadpool executor, also updated progress tracking displayed in the standard output.
Potential impacts
None. Changes introduced are backwards compatible.
Steps to test
PR Tasks