Move to Closure-compiler Repository

[ChadKillingsworth]

Can these just be moved to the closure-compiler contrib/externs folder? Those externs are distributed via NPM and published every release - (every 4-6 weeks)?

Googlers can still submit internal CLs to update them.

[jklein24]

I've talks about this briefly with @MatrixFrog and I think I agree that these should live in contrib/externs. @rictic @garlicnation, what do you guys think?

[MatrixFrog]

If it's in our repo then we (jscompiler team) will need to approve changes but if it's in contrib and the change is coming from Polymer team (or reviewed by Polymer team) then we'll probably just LGTM it unless we see anything blatantly wrong. So yeah it makes sense to me (which is what I said the last time we talked about this, I think? I don't remember 😛 ). Please make the change in our internal repo if you can, so we can easily make any BUILD/MOE-config changes at the same time.

[ChadKillingsworth]

If you intend to have/support multiple versions of the externs, we should probably create a folder for them (like the maps api externs).

If you really only expect to support the latest version or 2, there's no need.

[rictic]

We only intend to support at most two versions (current and a deprecated version).

It'd be nice to be able to piggyback on your MOE integration as well.

[danbeam]

from what I understand, @externs are a js-like syntax for describing objects/environments that don't have a pure JS implementation. otherwise you just ... depend on the JS implementation.

I've talked with @jklein24 about how these externs are kind of a misuse of this system. they partially duplicate an API in a hand-rolled way. if we push them into closure compiler, I doubt this will ever change.

[ChadKillingsworth]

You misunderstand externs.

Externs are for providing type information to Closure-compiler for code that is not compatible with the ADVANCED_COMPILATION. Most externs are for external js libraries (like jQuery, angular, etc). Externs are a completely appropriate way to reference Polymer.

A better way would be for the Polymer source itself to be compatible with the compiler. However that would take some work and is a longer term project. Even in that case externs still have their place for cases when you do not want to compile and bundle the source of Polymer in with your component code.

[danbeam]

A better way would be for the Polymer source itself to be compatible with the compiler.

agree with this, but...

You misunderstand externs.

...fine by me, then.

[ChadKillingsworth]

A better way would be for the Polymer source itself to be compatible with the compiler.

@danbeam If the Polymer team would like help with making such a change, I'm open to jumping in and helping. I have an excellent grasp of what is required. Feel free to ping me off github for this.

[MatrixFrog]

We're working on this internally. It's one of those things that's taking longer than you might expect (partly just because I was out all of last week), but I suspect it will get done this week.

[rictic]

And a note about making the core library compilable: this is currently the plan for the next major rev of Polymer.

[Dominator008]

Closed by google/closure-compiler@f7c7ead.