Skip to content

Inconsistent defaults for HttpClientConfiguration #5288

@at055612

Description

@at055612

In the no-args ctor we have

        timeout = StroomDuration.ofMinutes(3);
        connectionTimeout = StroomDuration.ofMinutes(3);
        connectionRequestTimeout = StroomDuration.ofMinutes(3);

but in the JsonCreator ctor we have

        this.timeout = Objects
                .requireNonNullElse(timeout, StroomDuration.ofMillis(500));
        this.connectionTimeout = Objects
                .requireNonNullElse(connectionTimeout, StroomDuration.ofMillis(500));
        this.connectionRequestTimeout = Objects
                .requireNonNullElse(connectionRequestTimeout, StroomDuration.ofMillis(500));

Both should be using the same default value so there is no ambiguity over which default is used.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions