Skip to content

Commit d62a051

Browse files
authored
Fix wrong OR to AND in BUILD_TESTING and PROJECT_IS_TOP_LEVEL logic (#9)
1 parent 5cf5ccc commit d62a051

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,6 @@ include(CTest)
137137
# or if serial_cpp_FORCE_RESPECT_BUILD_TESTING is ON, so if you include the project
138138
# via FetchContent or add_subdirectory and if you want to compile tests, you
139139
# need to set both BUILD_TESTING and serial_cpp_FORCE_RESPECT_BUILD_TESTING to ON
140-
if(BUILD_TESTING OR (PROJECT_IS_TOP_LEVEL OR serial_cpp_FORCE_RESPECT_BUILD_TESTING))
140+
if(BUILD_TESTING AND (PROJECT_IS_TOP_LEVEL OR serial_cpp_FORCE_RESPECT_BUILD_TESTING))
141141
add_subdirectory(tests)
142142
endif()

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ include(FetchContent)
5353
FetchContent_Declare(
5454
serial_cpp
5555
GIT_REPOSITORY https://github.com/ami-iit/serial_cpp.git
56-
GIT_TAG v1.3.2 # or use the tag or commit you prefer
56+
GIT_TAG v1.3.3 # or use the tag or commit you prefer
5757
)
5858
5959
FetchContent_MakeAvailable(serial_cpp)

package.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?xml version="1.0"?>
22
<package>
33
<name>serial_cpp</name>
4-
<version>1.3.2</version>
4+
<version>1.3.3</version>
55
<description>
66
serial_cpp is a cross-platform, simple to use library for using serial ports on computers.
77
This library provides a C++, object oriented interface for interacting with RS-232

0 commit comments

Comments
 (0)