diff --git a/.skillset/changes/9eaf8cdb3454.md b/.skillset/changes/9eaf8cdb3454.md new file mode 100644 index 0000000..0699cb3 --- /dev/null +++ b/.skillset/changes/9eaf8cdb3454.md @@ -0,0 +1,4 @@ +Keep a performed manual check only on the Ran line when rewriting a PR body, so the rewrite does not state the check twice. + +Bump: patch +Scope: skill:pr-craft diff --git a/.skillset/changes/ledger.jsonl b/.skillset/changes/ledger.jsonl index 8d3dc50..0b4a623 100644 --- a/.skillset/changes/ledger.jsonl +++ b/.skillset/changes/ledger.jsonl @@ -100,3 +100,8 @@ {"createdAt":"2026-11-11T18:19:00.086Z","id":"evt-83ce69dedbf202b9","payload":{"reasonId":"7a9d8486c8a9","sourceUnits":[{"hashSchema":"skillset-source-unit-v3","selector":"skill:pr-craft","sourceHash":"sha256:2aa868811cb850514c53a72d5a235e15451047d5994e5ae44829b95957aa4057"}]},"schemaVersion":1,"type":"change.covered"} {"createdAt":"2026-11-11T18:19:00.655Z","id":"evt-c6d9e62fbbe73c3c","payload":{"reasonId":"5124e78bc3c1","sourceUnits":[{"hashSchema":"skillset-source-unit-v3","selector":"skill:pr-craft","sourceHash":"sha256:2aa868811cb850514c53a72d5a235e15451047d5994e5ae44829b95957aa4057"}]},"schemaVersion":1,"type":"change.covered"} {"createdAt":"2026-11-11T18:19:00.655Z","id":"evt-d7ab7cdf13378471","payload":{"reasonId":"c70cafeb3a81","sourceUnits":[{"hashSchema":"skillset-source-unit-v3","selector":"skill:pr-craft","sourceHash":"sha256:2aa868811cb850514c53a72d5a235e15451047d5994e5ae44829b95957aa4057"}]},"schemaVersion":1,"type":"change.covered"} +{"createdAt":"2026-11-11T19:04:32.617Z","id":"evt-7f21ad23edc47a7f","payload":{"bump":"patch","path":".skillset/changes/9eaf8cdb3454.md","reason":"Keep a performed manual check only on the Ran line when rewriting a PR body, so the rewrite does not state the check twice.","reasonId":"9eaf8cdb3454","sourceUnits":[{"hashSchema":"skillset-source-unit-v3","selector":"skill:pr-craft","sourceHash":"sha256:846ff48d7f29ad3b837113341781dbd59f6d1750bb32abae2afd16012ee11f54"}]},"schemaVersion":1,"type":"reason.created"} +{"createdAt":"2026-11-11T19:04:32.617Z","id":"evt-22726f34803e4349","payload":{"reasonId":"9eaf8cdb3454","sourceUnits":[{"hashSchema":"skillset-source-unit-v3","selector":"skill:pr-craft","sourceHash":"sha256:846ff48d7f29ad3b837113341781dbd59f6d1750bb32abae2afd16012ee11f54"}]},"schemaVersion":1,"type":"change.covered"} +{"createdAt":"2026-11-11T19:04:48.807Z","id":"evt-6dd1c587c066a427","payload":{"reasonId":"5124e78bc3c1","sourceUnits":[{"hashSchema":"skillset-source-unit-v3","selector":"skill:pr-craft","sourceHash":"sha256:846ff48d7f29ad3b837113341781dbd59f6d1750bb32abae2afd16012ee11f54"}]},"schemaVersion":1,"type":"change.covered"} +{"createdAt":"2026-11-11T19:04:48.807Z","id":"evt-a852ca1da39d27d4","payload":{"reasonId":"7a9d8486c8a9","sourceUnits":[{"hashSchema":"skillset-source-unit-v3","selector":"skill:pr-craft","sourceHash":"sha256:846ff48d7f29ad3b837113341781dbd59f6d1750bb32abae2afd16012ee11f54"}]},"schemaVersion":1,"type":"change.covered"} +{"createdAt":"2026-11-11T19:04:48.807Z","id":"evt-f8080c9f94db2354","payload":{"reasonId":"c70cafeb3a81","sourceUnits":[{"hashSchema":"skillset-source-unit-v3","selector":"skill:pr-craft","sourceHash":"sha256:846ff48d7f29ad3b837113341781dbd59f6d1750bb32abae2afd16012ee11f54"}]},"schemaVersion":1,"type":"change.covered"} diff --git a/.skillset/skills/pr-craft/SKILL.md b/.skillset/skills/pr-craft/SKILL.md index 42fb3a0..2d30dbe 100644 --- a/.skillset/skills/pr-craft/SKILL.md +++ b/.skillset/skills/pr-craft/SKILL.md @@ -241,7 +241,7 @@ If all of the following hold, rewrite the PR body into this shape: - Keep every fact a reviewer needs. Below the opening paragraph, state each fact once, in the section that owns it. Drop only what `### Leave out` lists. - Restate each verification claim in this skill's form: the command or check, and its result. Treat the original's claims as observed, and do not re-run the checks. - If a verification claim names neither a command nor an action a reviewer could repeat, keep the claim on the `Ran:` line and add "command not stated". Do not invent a command. -- If a verification claim is a manual check that names its action, keep it on the `Ran:` line with its result. It can also be offered as a reviewer step. +- If a verification claim is a manual check that names its action, keep it on the `Ran:` line with its result. Do not also add it as a reviewer step. - Do not mention the rewrite, the previous body, or what was not re-run. - Do not make the body longer than the original. Exception: if the original has no content for the opening paragraph, Context, Changes, or Verify, add only that content. - If the body names a tracker issue, move the issue to the link line. If the body does not say how the PR relates to the issue, use `Related to`. Do not guess `Closes`. diff --git a/skills/pr-craft/SKILL.md b/skills/pr-craft/SKILL.md index 5c34f3e..028d18d 100644 --- a/skills/pr-craft/SKILL.md +++ b/skills/pr-craft/SKILL.md @@ -244,7 +244,7 @@ If all of the following hold, rewrite the PR body into this shape: - Keep every fact a reviewer needs. Below the opening paragraph, state each fact once, in the section that owns it. Drop only what `### Leave out` lists. - Restate each verification claim in this skill's form: the command or check, and its result. Treat the original's claims as observed, and do not re-run the checks. - If a verification claim names neither a command nor an action a reviewer could repeat, keep the claim on the `Ran:` line and add "command not stated". Do not invent a command. -- If a verification claim is a manual check that names its action, keep it on the `Ran:` line with its result. It can also be offered as a reviewer step. +- If a verification claim is a manual check that names its action, keep it on the `Ran:` line with its result. Do not also add it as a reviewer step. - Do not mention the rewrite, the previous body, or what was not re-run. - Do not make the body longer than the original. Exception: if the original has no content for the opening paragraph, Context, Changes, or Verify, add only that content. - If the body names a tracker issue, move the issue to the link line. If the body does not say how the PR relates to the issue, use `Related to`. Do not guess `Closes`. diff --git a/skills/skillset.lock b/skills/skillset.lock index 1c36a9d..3f81120 100644 --- a/skills/skillset.lock +++ b/skills/skillset.lock @@ -64,9 +64,9 @@ ], "kind": "standalone-skill", "name": "pr-craft", - "outputHash": "sha256:425b168dc16e8da8cc155a1870c7128979431110eb3cf590e81ce5f416b85863", + "outputHash": "sha256:b92d9204083a6a27ccd9d9f5d3f3eb3749c5e0344a7e02796bf8c17580ca99ad", "outputPath": "pr-craft/SKILL.md", - "sourceHash": "sha256:ca07f8e1810f188b9ef0e5722be493eb0d5143c95c45f60bffe0c9530af57aac", + "sourceHash": "sha256:e2cbf0e4a4d449c100c7e240279eebc68f38f2c97ba56a440a9213ef337c77c4", "sourcePath": ".skillset/skills/pr-craft/SKILL.md", "version": "0.1.0" }, @@ -137,7 +137,7 @@ } ], "outputRoot": "skills", - "provenanceHash": "sha256:46485aa56997ce47069f8bcc747c605573ea9483c579694b176da2f41dc66663", + "provenanceHash": "sha256:872b61dcaf73c755346f123293e9b36c0a70027582af5d9bc93d22f61b1712df", "renderResults": [ { "destination": "skill",