vst3 wrapper causes pragma-pack warnings which can't be suppressed from outside the wrapper

[XiNNiW]

Forgive me if this is more a factor of my lack of skill with CMake but when using the clap wrapper I encountered warnings that I could not get rid of that originated in the vst3 codebase. Its the same warnings that are discussed here: https://forum.juce.com/t/juce-8-0-12-linux-vst-embedded-interface-pragma-pack-warnings/67852/7

They came to the conclusion that the warnings could be safely ignored. I have -Werror on for my project so I needed some way of suppressing them.

I added the following to my CMake:
target_compile_options(${VST3_TARGET}-clap-wrapper-vst3-lib PRIVATE -Wno-pragma-pack)

Which feels like it sort of breaks the encapsulation of the clap-wrapper cmake files.

Should clap-wrapper have a line in its cmake function for vst3 wrappers that suppresses these warnings? I would be happy to open a pull request if this is desired.

If not, perhaps there might be some way to pass flags through the cmake wrapper function?

What do folks think?

[baconpaul]

yeah lets add this to cmake/ vst3 support in the wrapper for sure.

steinberg would probably say 'clang isn't supported on linux' or something like that so i'm assuming they won't symmetrize with macOS soon. i agree making this outside breaks encapsulation

the other option is for you to apply werror to your code but not the wrapper code. thats been the strategy I've used. but still would be happy to merge the in wrapper cmake change

[XiNNiW]

thanks! sounds good.

here is a PR: #456