Skip to content

Commit caed2b3

Browse files
committed
expose some fields to be overridden
1 parent 7341638 commit caed2b3

6 files changed

Lines changed: 8 additions & 9 deletions

File tree

src/Package.hpp

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -144,13 +144,15 @@ class Package
144144
return binary;
145145
}
146146

147-
private:
148-
// Package attributes
149-
std::string pkg_name;
147+
// these are exposed, since they can be overridden in some contexts
150148
std::string title;
151149
std::string author;
152150
std::string short_desc;
153151
std::string long_desc;
152+
153+
private:
154+
// Package attributes
155+
std::string pkg_name;
154156
std::string version;
155157

156158
std::string license;

src/repos/GetRepo.hpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ class GetRepo : public Repo
1717
[[nodiscard]] std::string getZipUrl(const Package& package) const override;
1818
[[nodiscard]] std::string getIconUrl(const Package& package) const override;
1919

20-
private:
2120
[[maybe_unused]] std::vector<std::unique_ptr<Package>> loadPackages() override;
2221
};
2322
#endif

src/repos/LocalRepo.hpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,9 @@ class LocalRepo : public Repo
2424
[[nodiscard]] std::string getZipUrl(const Package& package) const override;
2525
[[nodiscard]] std::string getIconUrl(const Package& package) const override;
2626

27+
[[maybe_unused]] std::vector<std::unique_ptr<Package>> loadPackages() override;
28+
2729
private:
2830
std::string mPkg_path;
29-
[[maybe_unused]] std::vector<std::unique_ptr<Package>> loadPackages() override;
3031
};
3132
#endif

src/repos/OSCRepo.hpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ class OSCRepo : public Repo
1313
[[nodiscard]] std::string getZipUrl(const Package& package) const override;
1414
[[nodiscard]] std::string getIconUrl(const Package& package) const override;
1515

16-
private:
1716
[[maybe_unused]] std::vector<std::unique_ptr<Package>> loadPackages() override;
1817
};
1918
#endif

src/repos/Repo.hpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,8 @@ class Repo
4242

4343
static std::unique_ptr<Repo> createRepo(std::string_view name, std::string_view url, bool enabled, std::string_view type, std::string_view package_path);
4444

45-
private:
4645
virtual std::vector<std::unique_ptr<Package>> loadPackages() = 0;
47-
46+
private:
4847
friend Get;
4948
};
5049

src/repos/UniStoreRepo.hpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ class UniStoreRepo : public Repo
1313
[[nodiscard]] std::string getZipUrl(const Package& package) const override;
1414
[[nodiscard]] std::string getIconUrl(const Package& package) const override;
1515

16-
private:
1716
[[maybe_unused]] std::vector<std::unique_ptr<Package>> loadPackages() override;
1817
};
1918
#endif

0 commit comments

Comments
 (0)