From 8b483d6c2d95da455b77328e7343877e6e38ff9b Mon Sep 17 00:00:00 2001 From: Chadwick Boulay Date: Sun, 6 Sep 2026 22:17:58 -0400 Subject: [PATCH] Let PinkNoise's anti-alias filter follow the stream's chunk_dim WhiteNoiseProducer already declares chunk_dim="time" on what it emits, so the child Butterworth resolves to exactly the dimension it was pinned to. Passing axis="time" explicitly only asked ezmsg-sigproc 3.8 to warn about a setting no user of PinkNoise ever chose -- it is our internal wiring, not their configuration. No behaviour change, and no new version floor: the filter resolved this dimension before the setting was deprecated too. The rest of this package needs nothing. Every source that builds an AxisArray declares chunk_dim (noise, oscillator, dnss/lfp, dnss/spike), line_noise already resolves it, and dynamic_colored_noise preserves it through `replace`. The two remaining `axis=` sites -- CoordinateSpaces "ch" and AffineTransform "ch" -- name a channel axis, which is not going away. --- src/ezmsg/simbiophys/noise.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/ezmsg/simbiophys/noise.py b/src/ezmsg/simbiophys/noise.py index 3b14bd5..f8c9e9f 100644 --- a/src/ezmsg/simbiophys/noise.py +++ b/src/ezmsg/simbiophys/noise.py @@ -125,9 +125,11 @@ def _initialize_processors(settings: PinkNoiseSettings) -> dict[str, BaseProcess scale=settings.scale, ) ), - "filter": ButterworthFilterTransformer( - ButterworthFilterSettings(axis="time", order=1, cutoff=settings.cutoff) - ), + # No `axis`: WhiteNoiseProducer declares chunk_dim="time" on what it + # emits, so the filter resolves to the same dimension it was pinned + # to -- without asking ezmsg-sigproc to warn about a setting no user + # of PinkNoise ever chose. + "filter": ButterworthFilterTransformer(ButterworthFilterSettings(order=1, cutoff=settings.cutoff)), }