Adds v8 patch for missing ppc dict key#397
Merged
jwendell merged 1 commit intoenvoyproxy:release/v1.35from Oct 17, 2025
Merged
Conversation
Signed-off-by: Md.afsan Hossain <mdafsan.hossain@ibm.com>
Contributor
Author
|
@tedjpoole @jwendell Can you take a look? |
jwendell
requested changes
Oct 16, 2025
Member
jwendell
left a comment
jwendell
left a comment
There was a problem hiding this comment.
Upstream already has a patch file for ppc: https://github.com/envoyproxy/envoy/blob/release/v1.35/bazel/v8_ppc64le.patch
Please, submit your change there and then we will sync the repos once it lands there.
jwendell
approved these changes
Oct 17, 2025
Member
jwendell
left a comment
jwendell
left a comment
There was a problem hiding this comment.
Merging, as this will be revisited in upstream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Fixes v8 build on ppc64le.
Additional Description: This PR fixes the following problem seen on ppc while building v8.
Testing: Done locally.
Docs Changes: No.