Skip to content

[Windows] Properly handle/ignore archives and plain text files on upload #8589

@ltguillaume

Description

@ltguillaume

Description

The Windows desktop application keeps trying to upload files it doesn't recognize and throws a gazillion "Skipped" messages, overriding any real progress dialogs that show upload statuses. This process repeats itself for every monitored directory upon a restart of the application.

I see this happen for archives (such as *.zip) and any kind of file that contains plain text, such as

desktop.ini
*.ini
*.sfv
*.sha*

Log file:

[{TIMESTAMP}] [rndr] [info] Uploading 2 files
[{TIMESTAMP}] [rndr] [info] Upload desktop.ini | start
[{TIMESTAMP}] [rndr] [error] Upload failed for desktop.ini: Error: Could not deduce file type from the file's contents
    at l (ente://app/_next/static/chunks/pages/_app-947bb2d3725140ba.js:1:112554)
    at async A (ente://app/_next/static/chunks/pages/_app-947bb2d3725140ba.js:1:111952)
    at async eQ (ente://app/_next/static/chunks/pages/_app-947bb2d3725140ba.js:1:736939)
    at async eb (ente://app/_next/static/chunks/pages/_app-947bb2d3725140ba.js:1:734525)
    at async E.uploadNextItemInQueue (ente://app/_next/static/chunks/pages/_app-947bb2d3725140ba.js:188:1088308)
[{TIMESTAMP}] [rndr] [info] Upload desktop.ini | failed

I think the application should either manage a blacklist for files with these extensions; only handle known file extensions while ignoring the others (i.e. whitelist for uploads), or only show these error messages if the file extension is known (i.e. whitelist for error messages).

Version

1.7.16

What product are you using?

Ente Photos

What platform are you using?

Windows

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions