Skip to content

Commit 73404f8

Browse files
authored
Use the RFC 9110 reason phrases for 413, 414 and 416 (#1328)
IANA's HTTP status code registry lists these as "Content Too Large", "URI Too Long" and "Range Not Satisfiable". RFC 9110 renamed all four of the phrases Plug carried from RFC 7231; 422 was updated in #1276 and these three were left behind. The old atoms are kept as aliases, using the same mechanism #1276 added, so put_status(:request_entity_too_large) keeps working. Co-authored-by: Dylan Pulver <dylanpulver@users.noreply.github.com>
1 parent 66b4836 commit 73404f8

2 files changed

Lines changed: 12 additions & 3 deletions

File tree

‎lib/plug/conn/status.ex‎

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ defmodule Plug.Conn.Status do
66
custom_statuses = Application.compile_env(:plug, :statuses, %{})
77

88
aliased_statuses = [
9+
{413, :request_entity_too_large},
10+
{414, :request_uri_too_long},
11+
{416, :requested_range_not_satisfiable},
912
{422, :unprocessable_entity}
1013
]
1114

@@ -46,10 +49,10 @@ defmodule Plug.Conn.Status do
4649
410 => "Gone",
4750
411 => "Length Required",
4851
412 => "Precondition Failed",
49-
413 => "Request Entity Too Large",
50-
414 => "Request-URI Too Long",
52+
413 => "Content Too Large",
53+
414 => "URI Too Long",
5154
415 => "Unsupported Media Type",
52-
416 => "Requested Range Not Satisfiable",
55+
416 => "Range Not Satisfiable",
5356
417 => "Expectation Failed",
5457
418 => "I'm a teapot",
5558
421 => "Misdirected Request",

‎test/plug/conn/status_test.exs‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,9 @@ defmodule Plug.Conn.StatusTest do
1414
assert Status.code(:non_authoritative_information) == 203
1515
assert Status.code(:not_found) == 404
1616
assert Status.code(:unprocessable_content) == 422
17+
assert Status.code(:content_too_large) == 413
18+
assert Status.code(:uri_too_long) == 414
19+
assert Status.code(:range_not_satisfiable) == 416
1720
end
1821

1922
test "code for custom status return the numeric code" do
@@ -22,6 +25,9 @@ defmodule Plug.Conn.StatusTest do
2225

2326
test "code for aliased statuses" do
2427
assert Status.code(:unprocessable_entity) == 422
28+
assert Status.code(:request_entity_too_large) == 413
29+
assert Status.code(:request_uri_too_long) == 414
30+
assert Status.code(:requested_range_not_satisfiable) == 416
2531
end
2632

2733
test "code with both a built_in and custom code return the numeric code" do

0 commit comments

Comments
 (0)