@@ -2271,6 +2271,122 @@ defmodule Mint.HTTP2Test do
22712271 ] )
22722272 end
22732273
2274+ test "a raised header table size leaves the table size to the server" , % { conn: conn } do
2275+ { conn , ref } = open_request ( conn )
2276+
2277+ assert_recv_frames [ headers ( stream_id: stream_id ) ]
2278+
2279+ # The server picks a 64 byte table and stores ":status: 404" in it, which takes 42 bytes.
2280+ assert { :ok , % HTTP2 { } = conn , responses } =
2281+ stream_frames ( conn , [
2282+ headers (
2283+ stream_id: stream_id ,
2284+ hbf: << 0x3F , 0x21 , 0x48 , 3 , "404" >> ,
2285+ flags: set_flags ( :headers , [ :end_headers , :end_stream ] )
2286+ )
2287+ ] )
2288+
2289+ assert [ { :status , ^ ref , 404 } , { :headers , ^ ref , [ ] } , { :done , ^ ref } ] = responses
2290+
2291+ { :ok , conn } = HTTP2 . put_settings ( conn , header_table_size: 8192 )
2292+ assert_recv_frames [ settings ( params: [ header_table_size: 8192 ] ) ]
2293+
2294+ assert { :ok , % HTTP2 { } = conn , [ ] } =
2295+ stream_frames ( conn , [ settings ( flags: set_flags ( :settings , [ :ack ] ) , params: [ ] ) ] )
2296+
2297+ # The server didn't ask for more room, so storing ":status: 500" evicts ":status: 404".
2298+ { conn , ref } = open_request ( conn )
2299+
2300+ assert_recv_frames [ headers ( stream_id: stream_id ) ]
2301+
2302+ assert { :ok , % HTTP2 { } = conn , responses } =
2303+ stream_frames ( conn , [
2304+ headers (
2305+ stream_id: stream_id ,
2306+ hbf: << 0x48 , 3 , "500" >> ,
2307+ flags: set_flags ( :headers , [ :end_headers , :end_stream ] )
2308+ )
2309+ ] )
2310+
2311+ assert [ { :status , ^ ref , 500 } , { :headers , ^ ref , [ ] } , { :done , ^ ref } ] = responses
2312+
2313+ { conn , _ref } = open_request ( conn )
2314+
2315+ assert_recv_frames [ headers ( stream_id: stream_id ) ]
2316+
2317+ assert { :error , % HTTP2 { } = conn , error , [ ] } =
2318+ stream_frames ( conn , [
2319+ headers (
2320+ stream_id: stream_id ,
2321+ hbf: << 0xBF >> ,
2322+ flags: set_flags ( :headers , [ :end_headers , :end_stream ] )
2323+ )
2324+ ] )
2325+
2326+ assert_http2_error error , { :compression_error , debug_data }
2327+ assert debug_data =~ "unable to decode headers: {:index_not_found, 63}"
2328+
2329+ assert_recv_frames [ goaway ( error_code: :compression_error ) ]
2330+
2331+ refute HTTP2 . open? ( conn )
2332+ end
2333+
2334+ test "a lowered header table size has to be signalled by the server" , % { conn: conn } do
2335+ conn = fill_server_header_table ( conn )
2336+
2337+ { :ok , conn } = HTTP2 . put_settings ( conn , header_table_size: 0 )
2338+ assert_recv_frames [ settings ( params: [ header_table_size: 0 ] ) ]
2339+
2340+ assert { :ok , % HTTP2 { } = conn , [ ] } =
2341+ stream_frames ( conn , [ settings ( flags: set_flags ( :settings , [ :ack ] ) , params: [ ] ) ] )
2342+
2343+ { conn , _ref } = open_request ( conn )
2344+
2345+ assert_recv_frames [ headers ( stream_id: stream_id ) ]
2346+
2347+ assert { :error , % HTTP2 { } = conn , error , [ ] } =
2348+ stream_frames ( conn , [
2349+ headers (
2350+ stream_id: stream_id ,
2351+ hbf: << 0x88 >> ,
2352+ flags: set_flags ( :headers , [ :end_headers , :end_stream ] )
2353+ )
2354+ ] )
2355+
2356+ assert_http2_error error , { :compression_error , debug_data }
2357+ assert debug_data =~ "unable to decode headers: :missing_size_update"
2358+
2359+ assert_recv_frames [ goaway ( error_code: :compression_error ) ]
2360+
2361+ refute HTTP2 . open? ( conn )
2362+ end
2363+
2364+ test "a response that signals the lowered header table size is accepted" , % { conn: conn } do
2365+ conn = fill_server_header_table ( conn )
2366+
2367+ { :ok , conn } = HTTP2 . put_settings ( conn , header_table_size: 0 )
2368+ assert_recv_frames [ settings ( params: [ header_table_size: 0 ] ) ]
2369+
2370+ assert { :ok , % HTTP2 { } = conn , [ ] } =
2371+ stream_frames ( conn , [ settings ( flags: set_flags ( :settings , [ :ack ] ) , params: [ ] ) ] )
2372+
2373+ { conn , ref } = open_request ( conn )
2374+
2375+ assert_recv_frames [ headers ( stream_id: stream_id ) ]
2376+
2377+ assert { :ok , % HTTP2 { } = conn , responses } =
2378+ stream_frames ( conn , [
2379+ headers (
2380+ stream_id: stream_id ,
2381+ hbf: << 0x20 , 0x88 >> ,
2382+ flags: set_flags ( :headers , [ :end_headers , :end_stream ] )
2383+ )
2384+ ] )
2385+
2386+ assert [ { :status , ^ ref , 200 } , { :headers , ^ ref , [ ] } , { :done , ^ ref } ] = responses
2387+ assert HTTP2 . open? ( conn )
2388+ end
2389+
22742390 @ tag connect_options: [
22752391 receive_window_update_threshold: 8 ,
22762392 client_settings: [ initial_window_size: 16 ]
@@ -3051,6 +3167,26 @@ defmodule Mint.HTTP2Test do
30513167 end
30523168 end
30533169
3170+ defp fill_server_header_table ( conn ) do
3171+ { conn , ref } = open_request ( conn )
3172+
3173+ assert_recv_frames [ headers ( stream_id: stream_id ) ]
3174+
3175+ # ":status: 404" stored with incremental indexing, 42 bytes in the server's table.
3176+ assert { :ok , % HTTP2 { } = conn , responses } =
3177+ stream_frames ( conn , [
3178+ headers (
3179+ stream_id: stream_id ,
3180+ hbf: << 0x48 , 3 , "404" >> ,
3181+ flags: set_flags ( :headers , [ :end_headers , :end_stream ] )
3182+ )
3183+ ] )
3184+
3185+ assert [ { :status , ^ ref , 404 } , { :headers , ^ ref , [ ] } , { :done , ^ ref } ] = responses
3186+
3187+ conn
3188+ end
3189+
30543190 defp start_server_async ( _context ) do
30553191 { :ok , port , server_socket_task } = TestServer . listen_and_accept ( )
30563192 % { server_port: port , server_socket_task: server_socket_task }
0 commit comments