chore(lint): enable e18e rules with oxlint (#6075)

Add `@e18e/eslint-plugin` to `oxlint` to detect avoidable allocations
and older JavaScript patterns. Use the shared dependency catalog for the
plugin version. Enable 12 compatible rules and update existing code to
satisfy them.

Keep dependency replacements and regular-expression relocation outside
this change. Disable `.concat()` spread fixes because `oxlint` lacks the
required type information. Defer the three array-copy rules because the
TypeScript configuration targets `ES2022`.


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Chores**
* Updated code quality checks to enforce modern JavaScript patterns
across the project.

* **Refactor**
* Applied consistent modern JavaScript methods across application logic
and tests. These changes preserve existing behavior.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Author: fengmk2

.oxlintrc.json

@@ -1,5 +1,6 @@
 {
   "$schema": "./node_modules/oxlint/configuration_schema.json",
+  "jsPlugins": ["@e18e/eslint-plugin"],
   "env": {
     "node": true
   },
@@ -11,6 +12,18 @@
   ],
   "rules": {
     "no-unused-vars": "error",
-    "preserve-caught-error": "error"
+    "preserve-caught-error": "error",
+    "e18e/prefer-array-at": "error",
+    "e18e/prefer-array-fill": "error",
+    "e18e/prefer-includes": "error",
+    "e18e/prefer-nullish-coalescing": "error",
+    "e18e/prefer-object-has-own": "error",
+    "e18e/prefer-url-canparse": "error",
+    "e18e/prefer-array-from-map": "error",
+    "e18e/prefer-timer-args": "error",
+    "e18e/prefer-date-now": "error",
+    "e18e/prefer-regex-test": "error",
+    "e18e/prefer-array-some": "error",
+    "e18e/prefer-string-fromcharcode": "error"
   }
 }

.utoo.toml

@@ -2,6 +2,7 @@
 
 [catalog]
 "@clack/prompts" = "^0.11.0"
+"@e18e/eslint-plugin" = "^0.8.1"
 "@eggjs/compressible" = "^3.0.0"
 "@eggjs/cookies" = "^3.1.0"
 "@eggjs/ip" = "^2.1.0"

package.json

@@ -51,6 +51,7 @@
     "version:rc": "node scripts/version.js prerelease --prerelease-tag=rc"
   },
   "devDependencies": {
+    "@e18e/eslint-plugin": "catalog:",
     "@eggjs/bin": "workspace:*",
     "@eggjs/tsconfig": "workspace:*",
     "@oxc-node/core": "catalog:",

packages/cookies/test/cookies.test.ts

@@ -28,7 +28,7 @@ describe('test/cookies.test.ts', () => {
     cookies.ctx.request.headers.cookie = cookie;
     const value = cookies.get('foo', { encrypt: true });
     assert(value, 'bar');
-    assert(cookie.indexOf('bar') === -1);
+    assert(!cookie.includes('bar'));
   });
 
   it('should cache keygrip', () => {
@@ -60,8 +60,8 @@ describe('test/cookies.test.ts', () => {
     cookies.ctx.request.headers.cookie = cookie;
     const value = cookies.get('foo', { encrypt: true });
     assert(value, 'bar');
-    assert(cookie.indexOf('bar') === -1);
-    assert(cookie.indexOf('sig') === -1);
+    assert(!cookie.includes('bar'));
+    assert(!cookie.includes('sig'));
   });
 
   it('should work with secure ok', () => {
@@ -116,8 +116,8 @@ describe('test/cookies.test.ts', () => {
     const cookies = Cookies();
     cookies.set('foo', 'bar', { signed: true });
     const cookie = cookies.ctx.response.headers['set-cookie'].join(';');
-    assert(cookie.indexOf('foo=bar') >= 0);
-    assert(cookie.indexOf('foo.sig=') >= 0);
+    assert(cookie.includes('foo=bar'));
+    assert(cookie.includes('foo.sig='));
     cookies.ctx.request.headers.cookie = cookie;
     let value = cookies.get('foo', { signed: true });
     assert(value === 'bar');

packages/egg/src/app/extend/request.ts

@@ -173,7 +173,7 @@ export default class Request extends EggCoreRequest {
    */
   get acceptJSON(): boolean {
     if (this.path.endsWith('.json')) return true;
-    if (this.response.type && this.response.type.indexOf('json') >= 0) return true;
+    if (this.response.type && this.response.type.includes('json')) return true;
     if (this.accepts('html', 'text', 'json') === 'json') return true;
     return false;
   }

packages/egg/src/lib/application.ts

@@ -79,7 +79,7 @@ export class Application extends EggApplicationCore {
       return;
     }
 
-    const body = raw.body == null ? DEFAULT_BAD_REQUEST_HTML : raw.body;
+    const body = raw.body ?? DEFAULT_BAD_REQUEST_HTML;
     const headers = raw.headers || {};
     const status = raw.status || 400;
 

packages/egg/test/app/extend/application.test.ts

@@ -54,7 +54,7 @@ describe('test/app/extend/application.test.ts', () => {
           'config',
           'httpclient',
           'loggers',
-        ].every((p) => Object.prototype.hasOwnProperty.call(app.inspect(), p)),
+        ].every((p) => Object.hasOwn(app.inspect(), p)),
       );
       assert(app.inspect().name === 'demo');
     });

packages/egg/test/egg.test.ts

@@ -149,7 +149,8 @@ describe('test/egg.test.ts', { concurrent: false }, () => {
 
     it.skip('should disable timing after ready', () => {
       const json = app.timing.toJSON();
-      const last = json[json.length - 1];
+      const last = json.at(-1);
+      assert(last);
       app.timing.start('a');
       app.timing.end('a');
       const json2 = app.timing.toJSON();

packages/egg/test/lib/core/loader/load_service.test.ts

@@ -32,8 +32,8 @@ describe('test/lib/core/loader/load_service.test.ts', () => {
   it('should service support es6', async () => {
     app = createApp('apps/services_loader_verify');
     await app.ready();
-    assert(Object.prototype.hasOwnProperty.call(app.serviceClasses, 'foo'));
-    assert(['bar'].every((p) => Object.prototype.hasOwnProperty.call(app.serviceClasses.foo, p)));
+    assert(Object.hasOwn(app.serviceClasses, 'foo'));
+    assert(['bar'].every((p) => Object.hasOwn(app.serviceClasses.foo, p)));
   });
 
   it('should support extend app.Service class', async () => {

packages/egg/test/lib/core/messenger/ipc.test.ts

@@ -162,7 +162,7 @@ describe.skip('test/lib/core/messenger/ipc.test.ts', () => {
     it('app should accept agent message', async () => {
       function count(data: string, key: string) {
         return data.split('\n').filter((line) => {
-          return line.indexOf(key) >= 0;
+          return line.includes(key);
         }).length;
       }
       await scheduler.wait(500);
@@ -189,7 +189,7 @@ describe.skip('test/lib/core/messenger/ipc.test.ts', () => {
     it('app should accept agent message', async () => {
       function count(data: string, key: string) {
         return data.split('\n').filter((line) => {
-          return line.indexOf(key) >= 0;
+          return line.includes(key);
         }).length;
       }