NB_SETUP_FMD - create_domains=False

[SQLThomasMVP]

When I set create_domains_False in Domain Settings code block, it still tries to create domain labeled workspaces in code block 'Deploy and create workspaces(Sub Domains)' It seems like the 'If create_domains' should be the first test in code block, then rest of code should follow

for sub_domain_name in sub_domain_names:
if create_domains:
create_fabric_sub_domain(domain_name, sub_domain_name)

for domain in domain_deployment:
    print(f"--------------------------")
    print(f"Updating Workspace: {domain['environment_name']}")
    deploy_workspaces(sub_domain_name,workspace=domain['workspaces']['code'],workspace_name=FrameworkName +' '+ sub_domain_name + ' CODE ('+domain['environment_short']+') FMD',  environment_name=domain['environment_name'], old_id=config["workspaces"]["workspace_gold_code"], mapping_table=mapping_table, tasks=tasks)
    deploy_workspaces(sub_domain_name,workspace=domain['workspaces']['data'],workspace_name=FrameworkName +' '+ sub_domain_name + ' DATA ('+domain['environment_short']+') FMD',  environment_name=domain['environment_name'], old_id=config["workspaces"]["workspace_gold_data"], mapping_table=mapping_table, tasks=tasks)
    deploy_workspaces(sub_domain_name,workspace=domain['workspaces']['reporting'],workspace_name=FrameworkName +' '+ sub_domain_name + ' REPORTING ('+domain['environment_short']+') FMD', environment_name=domain['environment_name'], old_id=config["workspaces"]["workspace_reporting"], mapping_table=mapping_table, tasks=tasks)

[edkreuk]

Hi @SQLThomasMVP, this should be fixed in the latest version from last week. You need to download the Setup Notebook again, because there are some breaking changed to support the domains even better. The release notes are coming this week, the documentation on Github is already updated.
Let me know if this is working well for you

for business_domain_name in business_domain_names:
if create_domains:
create_fabric_domain(business_domain_name)