From de0e894e37c334950c0c0f1aaf072262b8b7d6e3 Mon Sep 17 00:00:00 2001 From: Florence Bockting Date: Mon, 20 Apr 2026 16:25:46 +0300 Subject: [PATCH 1/2] fix: support new loo_compare output --- R/fitlist.R | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/R/fitlist.R b/R/fitlist.R index d800f56..0a418e4 100644 --- a/R/fitlist.R +++ b/R/fitlist.R @@ -53,8 +53,15 @@ setMethod("modSel", "ubmsFitList", function(object, ...){ loos <- lapply(object@models, function(x) x@loo) elpd <- sapply(loos, function(x) x$estimates[1]) p_loo <- sapply(loos, function(x) x$estimates[2]) - compare <- loo::loo_compare(loos)[names(elpd),] - out <- data.frame(elpd=elpd, nparam=p_loo, elpd_diff=compare[,1], - se_diff=compare[,2]) + compare <- loo::loo_compare(loos) + if ("model" %in% colnames(compare)) { + compare <- compare[match(names(elpd), compare$model),] + out <- data.frame(elpd=elpd, nparam=p_loo, elpd_diff=compare[,2], + se_diff=compare[,3]) + } else { + compare <- loo::loo_compare(loos)[names(elpd),] + out <- data.frame(elpd=elpd, nparam=p_loo, elpd_diff=compare[,1], + se_diff=compare[,2]) + } out[order(out$elpd_diff, decreasing=TRUE),] }) From bd41f6cb68d4de1a893300b6196a4d947bf9a196 Mon Sep 17 00:00:00 2001 From: Florence Bockting Date: Wed, 22 Apr 2026 12:02:02 +0300 Subject: [PATCH 2/2] chore: update NEWS.md wrt upcoming changes in loo_compare() --- NEWS.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/NEWS.md b/NEWS.md index 30d0040..b3e11bf 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,3 +1,9 @@ +# ubms 1.2.9 (development) + +* Updated compatibility with upcoming changes to `loo_compare()` output + structure in the `loo` package (> 2.9.0), which now returns a data frame + instead of a matrix and includes additional diagnostic columns. + # ubms 1.2.8 * Add probs argument to summary method