diff --git a/content/post/2021-04-16-functional-programming-with-strava-data/index.Rmd b/content/post/2021-04-16-functional-programming-with-strava-data/index.Rmd index 1199411..4bbdfc8 100644 --- a/content/post/2021-04-16-functional-programming-with-strava-data/index.Rmd +++ b/content/post/2021-04-16-functional-programming-with-strava-data/index.Rmd @@ -57,7 +57,7 @@ tidyfunc <- strav_data %>% # removes activities with no duration (which rules out manually entered activities where no time is supplied) and also incorrect calculations where Strava defines the an average speed that is higher than the max speed (this most often occurs in swimming) - +## Comment by Shijing: I like how you added comment to explain what your code is doing. This is really helpful for people to learn. ``` After our data has a first-pass-tidy, we want to sort out which activities occurred frequently enough that they would be useful to display visually. In our view, having 98% of your activities comprise three different types (e.g., hiking, running, and biking), and 2% of your activities comprise 4 types (e.g., stand-up paddle boarding, walking, rock climbing, and jump rope), then your visualization will be skewed. It is certainly possible to select specific activities to visualize, and this will be something you can read more about later. For now, we're going to pair down our data to activity types that occur most commonly. diff --git a/content/post/2021-04-16-functional-programming-with-strava-data/paralleliterations.Rmd b/content/post/2021-04-16-functional-programming-with-strava-data/paralleliterations.Rmd index cc3db4d..785ae8a 100644 --- a/content/post/2021-04-16-functional-programming-with-strava-data/paralleliterations.Rmd +++ b/content/post/2021-04-16-functional-programming-with-strava-data/paralleliterations.Rmd @@ -94,3 +94,6 @@ walk2(paths, final_plots$eugeneroads, ggsave, ```` +### Overall comment by Shijing: + +I think how you incorporate comment as explanation for your code is really friendly for viewers, especially for those who are less confident with coding. The language use for the blog (in `jd_post.Rmd`) is intriguing to read. The steps are broken down nicely, and linking blog posts together for your blog is a good idea for viewers to navigate. One potential improvement in the future could be displaying and explaining outputs briefly (or at least a part of a output by using `head()`) to complement your explanation of code so that people know what to expect if they want to adapt your code. I never use `walk2()` before, which is something new I learned!