Upgrade Examiner app (bcgov#972)

dimak1 · dimak1 · commit eac8a5da7cc4 · 2025-12-23T14:23:52.000-08:00
* chore: upgrade Examiner app packages

* chore: update unit tests in Examiner app, use i18n from base layer

* chore(tests): enable unit tests in Host app
diff --git a/strr-examiner-web/app/components/ActionButtons.vue b/strr-examiner-web/app/components/ActionButtons.vue
@@ -2,7 +2,7 @@
 import { refreshNuxtData } from 'nuxt/app'
 import isEqual from 'lodash/isEqual'
 
-const { t } = useI18n()
+const { t } = useNuxtApp().$i18n
 const { decisionIntent, isMainActionDisabled, isDecisionEmailValid } = useExaminerDecision()
 const {
   activeHeader, activeReg, isAssignedToUser,
diff --git a/strr-examiner-web/app/components/ApplicationInfoHeader.vue b/strr-examiner-web/app/components/ApplicationInfoHeader.vue
@@ -1,6 +1,6 @@
 <script setup lang="ts">
 
-const { t } = useI18n()
+const { t } = useNuxtApp().$i18n
 const exStore = useExaminerStore()
 const { activeHeader, activeReg, isFilingHistoryOpen } = storeToRefs(exStore)
 const { toggleFilingHistory, checkAndPerformAction } = useHostExpansion()
diff --git a/strr-examiner-web/app/components/ApprovalConditions.vue b/strr-examiner-web/app/components/ApprovalConditions.vue
@@ -1,6 +1,6 @@
 <script setup lang="ts">
 
-const { t } = useI18n()
+const { t } = useNuxtApp().$i18n
 const { preDefinedConditions, isMainActionDisabled } = useExaminerDecision()
 
 const selectedConditions = defineModel<string[]>('conditions', { required: true })
diff --git a/strr-examiner-web/app/components/AssignmentActions.vue b/strr-examiner-web/app/components/AssignmentActions.vue
@@ -1,5 +1,5 @@
 <script setup lang="ts">
-const { t } = useI18n()
+const { t } = useNuxtApp().$i18n
 const { assignApplication, unassignApplication, assignRegistration, unassignRegistration } = useExaminerStore()
 const { activeHeader, activeReg, isAssignedToUser } = storeToRefs(useExaminerStore())
 const { updateRouteAndButtons } = useExaminerRoute()
diff --git a/strr-examiner-web/app/components/ComposeNoc.vue b/strr-examiner-web/app/components/ComposeNoc.vue
@@ -8,7 +8,7 @@ const {
   isAssignedToUser,
   activeHeader
 } = storeToRefs(useExaminerStore())
-const { t } = useI18n()
+const { t } = useNuxtApp().$i18n
 const formSchema = computed(
   () =>
     [
diff --git a/strr-examiner-web/app/components/DecisionPanel.vue b/strr-examiner-web/app/components/DecisionPanel.vue
@@ -1,7 +1,7 @@
 <script setup lang="ts">
 import { onMounted } from 'vue'
 
-const { t } = useI18n()
+const { t } = useNuxtApp().$i18n
 const { showDecisionPanel, decisionIntent, preDefinedConditions, resetDecision } = useExaminerDecision()
 const {
   isApplication,
diff --git a/strr-examiner-web/app/components/DocumentUpload.vue b/strr-examiner-web/app/components/DocumentUpload.vue
@@ -1,7 +1,7 @@
 <script setup lang="ts">
 import DocumentUploadSelect from '~/components/document/upload/Select.vue'
 
-const { t } = useI18n()
+const { t } = useNuxtApp().$i18n
 const exStore = useExaminerStore()
 const docStore = useExaminerDocumentStore()
 const { activeReg, isApplication, activeHeader } = storeToRefs(exStore)
diff --git a/strr-examiner-web/app/components/Host/Expansion/EditRentalUnitForm.vue b/strr-examiner-web/app/components/Host/Expansion/EditRentalUnitForm.vue
@@ -3,7 +3,7 @@ import { z } from 'zod'
 import type { Form } from '#ui/types'
 import isEqual from 'lodash/isEqual'
 
-const { t } = useI18n()
+const { t } = useNuxtApp().$i18n
 const emit = defineEmits<{
   close: [void],
   addressUpdated: [void]
diff --git a/strr-examiner-web/app/components/Host/Expansion/Owners.vue b/strr-examiner-web/app/components/Host/Expansion/Owners.vue
@@ -8,7 +8,7 @@ defineEmits<{
 const exStore = useExaminerStore()
 const { activeReg, isApplication } = storeToRefs(exStore)
 
-const { t } = useI18n()
+const { t } = useNuxtApp().$i18n
 
 const columns = [
   { key: 'name', label: t('label.name') },
diff --git a/strr-examiner-web/app/components/Host/SubHeader.vue b/strr-examiner-web/app/components/Host/SubHeader.vue
@@ -9,7 +9,7 @@ const {
   isAssignedToUser
 } = storeToRefs(useExaminerStore())
 const { openEditRentalUnitForm } = useHostExpansion()
-const { t } = useI18n()
+const { t } = useNuxtApp().$i18n
 const alertFlags = reactive(useFlags())
 const { isFeatureEnabled } = useFeatureFlags()
 const canEditApplicationAddress = isFeatureEnabled('enable-examiner-edit-address-application')
diff --git a/strr-examiner-web/app/components/Host/SupportingInfo.vue b/strr-examiner-web/app/components/Host/SupportingInfo.vue
@@ -7,7 +7,7 @@ import { useFlags } from '~/composables/useFlags'
 
 const exStore = useExaminerStore()
 const { activeReg, isApplication } = storeToRefs(exStore)
-const { t } = useI18n()
+const { t } = useNuxtApp().$i18n
 const alertFlags = reactive(useFlags())
 const { isFeatureEnabled } = useFeatureFlags()
 const isBusinessLicenseDocumentUploadEnabled = isFeatureEnabled('enable-business-license-document-upload')
diff --git a/strr-examiner-web/app/components/RegistrationInfoHeader.vue b/strr-examiner-web/app/components/RegistrationInfoHeader.vue
@@ -1,6 +1,6 @@
 <script setup lang="ts">
 
-const { t } = useI18n()
+const { t } = useNuxtApp().$i18n
 const exStore = useExaminerStore()
 const { activeReg, activeHeader, isFilingHistoryOpen } = storeToRefs(exStore)
 const { toggleFilingHistory, checkAndPerformAction } = useHostExpansion()
diff --git a/strr-examiner-web/app/components/Strata/Expansion/Buildings.vue b/strr-examiner-web/app/components/Strata/Expansion/Buildings.vue
@@ -1,5 +1,5 @@
 <script setup lang="ts">
-const { t } = useI18n()
+const { t } = useNuxtApp().$i18n
 const exStore = useExaminerStore()
 const { activeReg } = storeToRefs(exStore)
 
diff --git a/strr-examiner-web/app/components/Strata/SupportingInfo.vue b/strr-examiner-web/app/components/Strata/SupportingInfo.vue
@@ -4,7 +4,7 @@ import { ConnectPageSection } from '#components'
 const exStore = useExaminerStore()
 const { activeReg, isApplication } = storeToRefs(exStore)
 
-const { t } = useI18n()
+const { t } = useNuxtApp().$i18n
 
 // show all documents except those uploaded during NOC
 const applicationDocumentsConfig: SupportingDocumentsConfig = {
diff --git a/strr-examiner-web/app/components/SupportingDocuments.vue b/strr-examiner-web/app/components/SupportingDocuments.vue
@@ -5,7 +5,7 @@ const props = defineProps<{
   config?: SupportingDocumentsConfig
 }>()
 
-const { t } = useI18n()
+const { t } = useNuxtApp().$i18n
 const exStore = useExaminerStore()
 const { openDocInNewTab } = exStore
 const { activeReg, activeHeader, isApplication } = storeToRefs(exStore)
diff --git a/strr-examiner-web/app/components/Table/Header/Select.vue b/strr-examiner-web/app/components/Table/Header/Select.vue
@@ -1,7 +1,7 @@
 <script setup lang="ts">
 import type { TableColumn } from '#ui/types'
 import type { TableSort } from '~/types/table-sort'
-const { t } = useI18n()
+const { t } = useNuxtApp().$i18n
 const props = defineProps<{
   column: TableColumn
   options: Array<{
diff --git a/strr-examiner-web/app/composables/useExaminerActions.ts b/strr-examiner-web/app/composables/useExaminerActions.ts
@@ -2,7 +2,7 @@ import { ApplicationActionsE, RegistrationActionsE } from '@/enums/actions'
 
 export const useExaminerActions = () => {
   const strrModal = useStrrModals()
-  const { t } = useI18n()
+  const { t } = useNuxtApp().$i18n
   const { handleButtonLoading } = useButtonControl()
 
   /**
diff --git a/strr-examiner-web/app/composables/useHostExpansion.ts b/strr-examiner-web/app/composables/useHostExpansion.ts
@@ -10,7 +10,7 @@ export const useHostExpansion = () => {
   const { startEditRentalUnitAddress, resetEditRentalUnitAddress } = useExaminerStore()
   const { isFilingHistoryOpen, isEditingRentalUnit, hasUnsavedRentalUnitChanges } = storeToRefs(useExaminerStore())
   const { openConfirmActionModal, close: closeConfirmActionModal } = useStrrModals()
-  const { t } = useI18n()
+  const { t } = useNuxtApp().$i18n
   isFilingHistoryOpen.value = false // reset so it's starts hidden by default
   resetEditRentalUnitAddress()
   function openHostOwners (
diff --git a/strr-examiner-web/app/layouts/examine.vue b/strr-examiner-web/app/layouts/examine.vue
@@ -1,7 +1,6 @@
 <script setup lang="ts">
 const { isAuthenticated } = useKeycloak()
 const headerOptions = useAppConfig().connect.core.header.options
-provide(headerOptionsSymbol, headerOptions)
 const localePath = useLocalePath()
 const { isApplication } = storeToRefs(useExaminerStore())
 const { isFeatureEnabled } = useFeatureFlags()
diff --git a/strr-examiner-web/app/layouts/examiner.vue b/strr-examiner-web/app/layouts/examiner.vue
@@ -1,7 +1,6 @@
 <script setup lang="ts">
 const localePath = useLocalePath()
 const headerOptions = useAppConfig().connect.core.header.options
-provide(headerOptionsSymbol, headerOptions)
 const { isAuthenticated } = useKeycloak()
 </script>
 <template>
diff --git a/strr-examiner-web/app/pages/dashboard.vue b/strr-examiner-web/app/pages/dashboard.vue
@@ -3,7 +3,7 @@ import isEmpty from 'lodash/isEmpty'
 import { sub } from 'date-fns'
 
 const localePath = useLocalePath()
-const { t } = useI18n()
+const { t } = useNuxtApp().$i18n
 // TODO: ApplicationStatus.FULL_REVIEW is temporary until we have reqs defined
 // const { limit, page, getApplicationList } = useStrrBasePermitList(undefined, undefined) // leaving this for reference
 // const { getAccountApplications } = useStrrApi() // leaving this for reference
diff --git a/strr-examiner-web/app/pages/examine/[applicationId].vue b/strr-examiner-web/app/pages/examine/[applicationId].vue
@@ -1,5 +1,5 @@
 <script setup lang="ts">
-const { t } = useI18n()
+const { t } = useNuxtApp().$i18n
 const route = useRoute()
 const { manageAction } = useExaminerActions()
 const { updateRouteAndButtons } = useExaminerRoute()
diff --git a/strr-examiner-web/app/pages/registration/[registrationId].vue b/strr-examiner-web/app/pages/registration/[registrationId].vue
@@ -1,5 +1,5 @@
 <script setup lang="ts">
-const { t } = useI18n()
+const { t } = useNuxtApp().$i18n
 const route = useRoute()
 const { manageAction } = useExaminerActions()
 const { updateRouteAndButtons } = useExaminerRoute()
diff --git a/strr-examiner-web/app/stores/document.ts b/strr-examiner-web/app/stores/document.ts
@@ -1,5 +1,5 @@
 export const useExaminerDocumentStore = defineStore('examiner/document', () => {
-  const { t } = useI18n()
+  const { t } = useNuxtApp().$i18n
   const { $strrApi } = useNuxtApp()
   const strrModal = useStrrModals()
   const exStore = useExaminerStore()
diff --git a/strr-examiner-web/app/stores/examiner.ts b/strr-examiner-web/app/stores/examiner.ts
@@ -2,7 +2,7 @@ import { z } from 'zod'
 
 export const useExaminerStore = defineStore('strr/examiner-store', () => {
   const { getAccountApplications } = useStrrApi()
-  const { t } = useI18n()
+  const { t } = useNuxtApp().$i18n
   const { $strrApi } = useNuxtApp()
   const strrModal = useStrrModals()
   const { kcUser } = useKeycloak()
diff --git a/strr-examiner-web/app/types/application-response.ts b/strr-examiner-web/app/types/application-response.ts
@@ -1,2 +1 @@
 export type HousApplicationResponse = HostApplicationResp | PlatformApplicationResp | StrataApplicationResp
-export type HousRegistrationResponse = HostRegistrationResp | StrataHotelRegistrationResp | PlatformRegistrationResp
diff --git a/strr-examiner-web/app/utils/format-helper.ts b/strr-examiner-web/app/utils/format-helper.ts
@@ -104,7 +104,7 @@ export function displayPhoneAndExt (
   if (!phoneNumber) {
     return undefined // let the caller handle the undefined state
   }
-  const { t } = useI18n()
+  const { t } = useNuxtApp().$i18n
   const countryCode = phoneCountryCode ? `+${phoneCountryCode}-` : ''
   const extension = phoneExt ? `, ${t('label.phoneExt')} ${phoneExt}` : ''
   return countryCode + displayFormattedPhone(phoneNumber) + extension
diff --git a/strr-examiner-web/i18n.config.ts b/strr-examiner-web/i18n.config.ts
diff --git a/strr-examiner-web/i18n/locales/en-CA.ts b/strr-examiner-web/i18n/locales/en-CA.ts
diff --git a/strr-examiner-web/i18n/locales/fr-CA.ts b/strr-examiner-web/i18n/locales/fr-CA.ts
diff --git a/strr-examiner-web/nuxt.config.ts b/strr-examiner-web/nuxt.config.ts
@@ -18,28 +18,24 @@ export default defineNuxtConfig({
       {
         name: 'English',
         code: 'en-CA',
-        iso: 'en-CA',
+        language: 'en-CA',
         dir: 'ltr',
         file: 'en-CA.ts'
       },
       {
         name: 'Français',
         code: 'fr-CA',
-        iso: 'fr-CA',
+        language: 'fr-CA',
         dir: 'ltr',
         file: 'fr-CA.ts'
       }
     ],
     strategy: 'prefix',
-    lazy: true,
-    langDir: 'locales',
-    defaultLocale: 'en-CA',
-    detectBrowserLanguage: false,
-    vueI18n: './i18n.config.ts'
+    defaultLocale: 'en-CA'
   },
 
   extends: [
-    ['github:bcgov/STRR/strr-base-web', { install: true }]
+    ['github:bcgov/STRR/strr-base-web#feature-app-security', { install: true }]
     // '../strr-base-web' // dev only
   ],
 
diff --git a/strr-examiner-web/package.json b/strr-examiner-web/package.json
@@ -2,7 +2,7 @@
   "name": "strr-examiner-web",
   "private": true,
   "type": "module",
-  "version": "0.0.91",
+  "version": "0.1.0",
   "scripts": {
     "build-check": "nuxt build",
     "build": "nuxt generate",
@@ -20,32 +20,32 @@
   },
   "devDependencies": {
     "@axe-core/playwright": "^4.9.1",
-    "@nuxt/devtools": "^2.4.0",
-    "@nuxt/image": "^1.10.0",
-    "@nuxt/test-utils": "3.16.0",
+    "@nuxt/devtools": "^3.1.1",
+    "@nuxt/image": "^2.0.0",
+    "@nuxt/test-utils": "3.21.0",
     "@nuxtjs/eslint-config-typescript": "^12.1.0",
     "@nuxtjs/eslint-module": "^4.1.0",
-    "@pinia/testing": "^0.1.3",
-    "@playwright/test": "^1.52.0",
+    "@pinia/testing": "^1.0.3",
+    "@playwright/test": "^1.57.0",
     "@testing-library/vue": "^8.1.0",
-    "@types/lodash": "^4.17.16",
+    "@types/lodash": "^4.17.21",
     "@types/uuid": "^10.0.0",
-    "@typescript-eslint/parser": "^7.15.0",
-    "@vitest/coverage-v8": "2.0.5",
+    "@typescript-eslint/parser": "^8.50.1",
+    "@vitest/coverage-v8": "3.2.4",
     "@vue/test-utils": "^2.4.6",
     "eslint": "^8.57.0",
     "eslint-plugin-tailwindcss": "^3.17.4",
-    "happy-dom": "^17.4.6",
-    "playwright-core": "^1.45.1",
+    "happy-dom": "^20.0.11",
+    "playwright-core": "^1.57.0",
     "sass": "^1.77.6",
-    "typescript": "^5.5.3",
-    "vitest": "2.0.5"
+    "typescript": "^5.9.3",
+    "vitest": "3.2.4"
   },
   "dependencies": {
-    "@daxiom/nuxt-core-layer-test": "^0.0.24",
-    "country-codes-list": "^1.6.11",
+    "@daxiom/nuxt-core-layer-test": "^0.0.29",
+    "country-codes-list": "^2.0.0",
     "nuxt": "3.15.4",
-    "uuid": "^11.0.3",
+    "uuid": "^11.1.0",
     "v-calendar": "^3.1.2"
   }
 }
diff --git a/strr-examiner-web/pnpm-lock.yaml b/strr-examiner-web/pnpm-lock.yaml
diff --git a/strr-examiner-web/tests/mocks/i18n.ts b/strr-examiner-web/tests/mocks/i18n.ts
diff --git a/strr-examiner-web/tests/unit/dashboard.spec.ts b/strr-examiner-web/tests/unit/dashboard.spec.ts
diff --git a/strr-examiner-web/tests/unit/host-application-flags.spec.ts b/strr-examiner-web/tests/unit/host-application-flags.spec.ts
diff --git a/strr-host-pm-web/tests/unit/application.spec.ts b/strr-host-pm-web/tests/unit/application.spec.ts
diff --git a/strr-host-pm-web/tests/unit/registration-renewal.spec.ts b/strr-host-pm-web/tests/unit/registration-renewal.spec.ts

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@ const {`
`8`	`8`	`isAssignedToUser,`
`9`	`9`	`activeHeader`
`10`	`10`	`} = storeToRefs(useExaminerStore())`
`11`		`-const { t } = useI18n()`
	`11`	`+const { t } = useNuxtApp().$i18n`
`12`	`12`	`const formSchema = computed(`
`13`	`13`	`() =>`
`14`	`14`	`[`