fix: handle invalid source map columns in Bun runtime#13
Open
deepshekhardas wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
1 issue found across 5 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/cli-v3/src/utilities/installSourceMapSupport.ts">
<violation number="1" location="packages/cli-v3/src/utilities/installSourceMapSupport.ts:16">
P2: This always installs source-map-support and drops existing `TRIGGER_SOURCE_MAPS` runtime controls (`false`, `0`, `node`), which changes configured behavior in worker entrypoints.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| * See: https://github.com/oven-sh/bun/issues/8087 | ||
| */ | ||
| export function installSourceMapSupport() { | ||
| sourceMapSupport.install({ |
There was a problem hiding this comment.
P2: This always installs source-map-support and drops existing TRIGGER_SOURCE_MAPS runtime controls (false, 0, node), which changes configured behavior in worker entrypoints.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/cli-v3/src/utilities/installSourceMapSupport.ts, line 16:
<comment>This always installs source-map-support and drops existing `TRIGGER_SOURCE_MAPS` runtime controls (`false`, `0`, `node`), which changes configured behavior in worker entrypoints.</comment>
<file context>
@@ -0,0 +1,32 @@
+ * See: https://github.com/oven-sh/bun/issues/8087
+ */
+export function installSourceMapSupport() {
+ sourceMapSupport.install({
+ handleUncaughtExceptions: false,
+ environment: "node",
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bun's runtime can produce source maps with column values of -1, which causes source-map@0.6.1 (used by source-map-support) to throw: "Column must be greater than or equal to 0, got -1"
This change extracts source-map-support installation into a shared utility that wraps prepareStackTrace so that if source map processing fails, it falls back to default stack trace formatting instead of crashing.
Closes triggerdotdev#3049
Summary by cubic
Prevents crashes in Bun caused by invalid
-1source map columns by installingsource-map-supportwith a safeprepareStackTracefallback. Also tightens task registration during execution and aligns workers to use the new utility. Closes triggerdotdev#3049.installSourceMapSupport()to wrapprepareStackTrace; on source map errors, fall back to default formatting instead of throwing.../utilities/installSourceMapSupport.js.NO_FILE_CONTEXTduring execution sotask()calls in run/lifecycle hooks aren’t dropped; cleared after run.resourceCatalog.setCurrentFileContext(...)argument order when loading tasks.Written for commit 10f2e9d. Summary will update on new commits. Review in cubic