Skip to content

fix: keep cards that only support formats before S16 usable - #298

Open
qaqland wants to merge 1 commit into
deepin-community:masterfrom
qaqland:skip-before-s16-fallback
Open

qaqland wants to merge 1 commit into
deepin-community:masterfrom
qaqland:skip-before-s16-fallback

Conversation

@qaqland

@qaqland qaqland commented Nov 6, 2026

Copy link
Copy Markdown
Member

api.alsa.skip-formats-before-s16 skipped every entry before the S16 ones in format_info[], so a sound card that only supports e.g. S24 ended up with no format at all and enum_pcm_formats() returned -ENOTSUP, making the device disappear.

Retry the enumeration without the filtering when nothing is left. The retry is bounded by a local flag, so a card without any usable format still fails with the existing "no format found" warning instead of looping, and devices that do support S16 keep the bandwidth workaround.

The patch is refreshed in place, no new quilt patch is added.

PMS: 361545

api.alsa.skip-formats-before-s16 skipped every entry before the S16 ones
in format_info[], so a sound card that only supports e.g. S24 ended up
with no format at all and enum_pcm_formats() returned -ENOTSUP, making
the device disappear.

Retry the enumeration without the filtering when nothing is left. The
retry is bounded by a local flag, so a card without any usable format
still fails with the existing "no format found" warning instead of
looping, and devices that do support S16 keep the bandwidth workaround.

The patch is refreshed in place, no new quilt patch is added.

PMS: 361545
Signed-off-by: qaqland <anguoli@uniontech.com>
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@deepin-ci-robot
deepin-ci-robot requested a review from myml November 6, 2026 09:00
@deepin-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from qaqland. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

TAG Bot

TAG: 1.6.4-1deepin30
EXISTED: no
DISTRIBUTION: unstable

@deepin-ci-robot

Copy link
Copy Markdown
Contributor

/hold
因为该quilt包的上游版本号变更,详情见: deepin-community/infra-settings#134

@uos-eng uos-eng left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@deepin-community-ci-bot

Copy link
Copy Markdown

TAG Bot

New tag: 1.6.4-1deepin30
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #297

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants