Repository navigation
fix(security): fix crash and overflow bugs in network-facing modules - #295
Open
deepin-ci-robot wants to merge 1 commit into
Conversation
module-filter-chain: fix NULL pointer dereference when pw_stream_dequeue_buffer returns NULL and out->requested is accessed outside the NULL check. module-zeroconf-discover: add NULL checks for name, type, host_name, address, and port from mDNS lookups that could be missing in malformed announcements. module-raop-sink: cap net.mtu to 9000 to prevent stack overflow via VLA uint32_t out[8 + mtu]. module-rtp-sap: fix buffer over-read in SDP "i=" line parsing that read past a self-inserted null terminator. Also fix fd leak when fd is 0 (fd > 0 should be fd >= 0). Changes: - Add debian/patches/fix-security-crash-overflow-network-modules.patch - Modify debian/patches/series - Modify debian/changelog Upstream: PipeWire/pipewire@4b64b81 Generated-By: glm-5.3-flash Co-Authored-By: deepin-ci-robot <packages@deepin.org>
Contributor
Author
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/hold |
|
TAG Bot TAG: 1.6.4-1deepin30 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Before the Change
Several network-facing modules had crash and overflow bugs reachable via malformed network input:
pw_stream_dequeue_bufferreturns NULL andout->requestedis accessed outside the NULL check.net.mtucould cause stack overflow via VLAuint32_t out[8 + mtu].i=line parsing that read past a self-inserted null terminator; fd leak when fd is 0 (fd > 0should befd >= 0).What This PR Changes
Backports upstream commit 4b64b81d21597602f57533375df8f967a01690e8 as a quilt patch. The module-zeroconf-discover changes were adapted to the Avahi-based implementation in this version (upstream rewrote the module to a spa_dict-based API): NULL checks for name/type in
resolver_cb,host_name"unknown" fallback, and a NULL check for the AvahiAddress before dereference.Problem Solved After the Change
Malformed mDNS announcements, oversized
net.mtusettings, malformed SDP lines, and stream dequeue failures no longer crash PipeWire or leak file descriptors.Changes
Upstream
PipeWire/pipewire@4b64b81
Generated-By: glm-5.3-flash
Co-Authored-By: deepin-ci-robot packages@deepin.org