SplitButton_BoundsAreNotInsideTitleBarElement in windows/Ghostty.Tests.Windows/Tabs/TitleBarPassthroughTests.cs was added in # 345 (profiles PR 4) as an Assert.Fail("TODO: wire WinUITestHost (shared with NewTabSplitButtonSmokeTests).") placeholder. It has been failing on every test run since.
Intended assertions per the inline comment:
- Find the SplitButton (
ButtonRoot) inside MainWindow.
- Find the element passed to
AppWindow.SetTitleBar (TabHost.CustomDragRegion = the cell-1 spacer).
- Compute
SplitButton.TransformToVisual(spacer).TransformBounds(Rect.Empty).
- Assert the SplitButton bounds are NOT contained within the spacer's bounds (i.e. the button lives in cell 0, not cell 1).
Resolution options
- Wire
WinUITestHost shared with NewTabSplitButtonSmokeTests and implement the four assertions above.
- Mark
[Fact(Skip = "TODO: ...")] until implemented, so the suite reports a known-skip rather than a hard fail.
Why now
The wintty-release bumper validation runs just test; this single failing test fails every bump PR's validation, so each pin advance has to be admin-merged regardless of what the patches look like. Resolving the test (or skipping it) restores the bumper's signal.
SplitButton_BoundsAreNotInsideTitleBarElementinwindows/Ghostty.Tests.Windows/Tabs/TitleBarPassthroughTests.cswas added in # 345 (profiles PR 4) as anAssert.Fail("TODO: wire WinUITestHost (shared with NewTabSplitButtonSmokeTests).")placeholder. It has been failing on every test run since.Intended assertions per the inline comment:
ButtonRoot) inside MainWindow.AppWindow.SetTitleBar(TabHost.CustomDragRegion= the cell-1 spacer).SplitButton.TransformToVisual(spacer).TransformBounds(Rect.Empty).Resolution options
WinUITestHostshared withNewTabSplitButtonSmokeTestsand implement the four assertions above.[Fact(Skip = "TODO: ...")]until implemented, so the suite reports a known-skip rather than a hard fail.Why now
The wintty-release bumper validation runs
just test; this single failing test fails every bump PR's validation, so each pin advance has to be admin-merged regardless of what the patches look like. Resolving the test (or skipping it) restores the bumper's signal.