-
Notifications
You must be signed in to change notification settings - Fork 14
Description
The generic surrounding component div element has an aria-invalid-HTML-attribute defined, which doesn't harm, but even also doesn't benefit from that attribute, as those don't change anything on generic elements.
- We might either want to change this
divto afieldset-HTML-element, on which anaria-invalid-HTML-attribute actually makes sense (needs to get verified) - Or remove that attribute in total, mainly to get clean and meaningful code.
core-web/packages/components/src/components/custom-select/custom-select.lite.tsx
Line 898 in 17989d0
| aria-invalid={state._validity === 'invalid'} |
Additionally some elements in the page are even also referencing this generic element via the form-HTML-attribute:
core-web/packages/components/src/components/custom-select/custom-select.lite.tsx
Line 1020 in 17989d0
form={state._id} core-web/packages/components/src/components/custom-select/custom-select.lite.tsx
Line 1052 in 17989d0
form={state._id} core-web/packages/components/src/components/custom-select/custom-select.lite.tsx
Line 1153 in 17989d0
form={state._id} core-web/packages/components/src/components/custom-select/custom-select.lite.tsx
Line 1175 in 17989d0
form={state._id}
Even also this reference doesn't make any sense to that generic div-HTML-element.
We should think about what we wanted to achieve by these references and remove or correct those depending on the purpose.
Metadata
Metadata
Assignees
Labels
Type
Projects
Status