feat(drive-abci): add shielded pool drive-abci integration (medusa part 3) (#3220)

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: QuantumExplorer

Cargo.lock

@@ -77,6 +77,18 @@ impl StateTransitionStructureValidation for ShieldTransitionV0 {
             );
         }
 
+        // amount must fit in i64 (Orchard protocol uses i64 internally for value_balance)
+        if self.amount > i64::MAX as u64 {
+            return SimpleConsensusValidationResult::new_with_error(
+                BasicError::ShieldedInvalidValueBalanceError(
+                    ShieldedInvalidValueBalanceError::new(
+                        "shield amount exceeds maximum allowed value".to_string(),
+                    ),
+                )
+                .into(),
+            );
+        }
+
         // Proof must not be empty
         let result = validate_proof_not_empty(&self.proof);
         if !result.is_valid() {

packages/rs-dpp/src/state_transition/state_transitions/shielded/shield_transition/v0/state_transition_validation.rs

@@ -24,6 +24,18 @@ impl StateTransitionStructureValidation for ShieldedTransferTransitionV0 {
             return result;
         }
 
+        // value_balance must be positive (it IS the fee for shielded transfers)
+        if self.value_balance == 0 {
+            return SimpleConsensusValidationResult::new_with_error(
+                BasicError::ShieldedInvalidValueBalanceError(
+                    ShieldedInvalidValueBalanceError::new(
+                        "shielded transfer value_balance must be greater than zero".to_string(),
+                    ),
+                )
+                .into(),
+            );
+        }
+
         // value_balance must fit in i64 (required for Orchard protocol)
         if self.value_balance > i64::MAX as u64 {
             return SimpleConsensusValidationResult::new_with_error(

packages/rs-dpp/src/state_transition/state_transitions/shielded/shielded_transfer_transition/v0/state_transition_validation.rs

@@ -82,6 +82,8 @@ derive_more = { version = "1.0", features = ["from", "deref", "deref_mut"] }
 async-trait = "0.1.77"
 console-subscriber = { version = "0.4", optional = true }
 bls-signatures = { git = "https://github.com/dashpay/bls-signatures", rev = "0842b17583888e8f46c252a4ee84cdfd58e0546f", optional = true }
+grovedb-commitment-tree = { git = "https://github.com/dashpay/grovedb", rev = "dd99ed1db0350e5f39127573808dd172c6bc2346" }
+nonempty = "0.11"
 
 [dev-dependencies]
 platform-version = { path = "../rs-platform-version", features = [
@@ -101,6 +103,7 @@ dpp = { path = "../rs-dpp", default-features = false, features = [
 drive = { path = "../rs-drive", features = ["fixtures-and-mocks"] }
 drive-proof-verifier = { path = "../rs-drive-proof-verifier" }
 strategy-tests = { path = "../strategy-tests" }
+grovedb-commitment-tree = { git = "https://github.com/dashpay/grovedb", rev = "dd99ed1db0350e5f39127573808dd172c6bc2346", features = ["client"] }
 assert_matches = "1.5.0"
 drive-abci = { path = ".", features = ["testing-config", "mocks"] }
 bls-signatures = { git = "https://github.com/dashpay/bls-signatures", rev = "0842b17583888e8f46c252a4ee84cdfd58e0546f" }
@@ -120,6 +123,8 @@ testing-config = []
 grovedbg = ["drive/grovedbg"]
 # `abci-server replay` command
 replay = ["dep:time", "tenderdash-abci/serde"]
+# Long-running shielded strategy tests (ZK proof generation)
+__shielded_strategy_tests = []
 [[bin]]
 name = "drive-abci"
 path = "src/main.rs"
@@ -128,4 +133,5 @@ path = "src/main.rs"
 unexpected_cfgs = { level = "warn", check-cfg = [
   'cfg(tokio_unstable)',
   'cfg(create_sdk_test_data)',
+  'cfg(feature, values("__shielded_strategy_tests"))',
 ] }

packages/rs-drive-abci/Cargo.toml

@@ -344,6 +344,21 @@ where
             platform_version,
         )?;
 
+        // Clean up expired compacted nullifier entries
+        self.cleanup_recent_block_storage_nullifiers(&block_info, transaction, platform_version)?;
+
+        // Record shielded pool anchor if the commitment tree changed this block.
+        // This stores block_height → anchor_bytes so shielded transactions can
+        // reference a recent anchor for spend authorization.
+        self.record_shielded_pool_anchor_if_changed(
+            block_proposal.height,
+            transaction,
+            platform_version,
+        )?;
+
+        // Prune anchors older than the configured retention depth
+        self.prune_shielded_pool_anchors(block_proposal.height, transaction, platform_version)?;
+
         // Pool withdrawals into transactions queue
 
         // Takes queued withdrawals, creates untiled withdrawal transaction payload, saves them to queue

packages/rs-drive-abci/src/execution/engine/run_block_proposal/v0/mod.rs

@@ -1,5 +1,7 @@
 mod add_process_epoch_change_operations;
 pub mod process_block_fees_and_validate_sum_trees;
+mod prune_shielded_pool_anchors;
+mod record_shielded_pool_anchor;
 
 #[cfg(test)]
 mod tests;

packages/rs-drive-abci/src/execution/platform_events/block_processing_end_events/mod.rs

@@ -0,0 +1,38 @@
+mod v0;
+
+use crate::error::execution::ExecutionError;
+use crate::error::Error;
+use crate::platform_types::platform::Platform;
+use crate::rpc::core::CoreRPCLike;
+use dpp::version::PlatformVersion;
+use drive::grovedb::Transaction;
+
+impl<C> Platform<C>
+where
+    C: CoreRPCLike,
+{
+    /// Prunes shielded pool anchors older than the configured retention depth.
+    pub(in crate::execution) fn prune_shielded_pool_anchors(
+        &self,
+        block_height: u64,
+        transaction: &Transaction,
+        platform_version: &PlatformVersion,
+    ) -> Result<(), Error> {
+        match platform_version
+            .drive_abci
+            .methods
+            .block_end
+            .prune_shielded_pool_anchors
+        {
+            None => Ok(()),
+            Some(0) => {
+                self.prune_shielded_pool_anchors_v0(block_height, transaction, platform_version)
+            }
+            Some(version) => Err(Error::Execution(ExecutionError::UnknownVersionMismatch {
+                method: "prune_shielded_pool_anchors".to_string(),
+                known_versions: vec![0],
+                received: version,
+            })),
+        }
+    }
+}

packages/rs-drive-abci/src/execution/platform_events/block_processing_end_events/prune_shielded_pool_anchors/mod.rs

@@ -0,0 +1,44 @@
+use crate::error::Error;
+use crate::platform_types::platform::Platform;
+use crate::rpc::core::CoreRPCLike;
+use dpp::version::PlatformVersion;
+use drive::grovedb::Transaction;
+
+impl<C> Platform<C>
+where
+    C: CoreRPCLike,
+{
+    /// Prunes anchors older than `shielded_anchor_retention_blocks` from the current height.
+    ///
+    /// Checks interval and retention depth conditions, then delegates to
+    /// `Drive::prune_shielded_pool_anchors` for the actual GroveDB operations.
+    pub(super) fn prune_shielded_pool_anchors_v0(
+        &self,
+        block_height: u64,
+        transaction: &Transaction,
+        platform_version: &PlatformVersion,
+    ) -> Result<(), Error> {
+        let event_constants = &platform_version
+            .drive_abci
+            .validation_and_processing
+            .event_constants;
+        let retention_blocks = event_constants.shielded_anchor_retention_blocks;
+        let pruning_interval = event_constants.shielded_anchor_pruning_interval;
+
+        // Only prune every N blocks to avoid unnecessary work
+        if !block_height.is_multiple_of(pruning_interval) {
+            return Ok(());
+        }
+
+        // Nothing to prune if we haven't reached the retention depth yet
+        if block_height <= retention_blocks {
+            return Ok(());
+        }
+
+        let cutoff_height = block_height - retention_blocks;
+
+        self.drive
+            .prune_shielded_pool_anchors(cutoff_height, transaction, platform_version)
+            .map_err(Error::Drive)
+    }
+}

packages/rs-drive-abci/src/execution/platform_events/block_processing_end_events/prune_shielded_pool_anchors/v0/mod.rs

@@ -0,0 +1,40 @@
+mod v0;
+
+use crate::error::execution::ExecutionError;
+use crate::error::Error;
+use crate::platform_types::platform::Platform;
+use crate::rpc::core::CoreRPCLike;
+use dpp::version::PlatformVersion;
+use drive::grovedb::Transaction;
+
+impl<C> Platform<C>
+where
+    C: CoreRPCLike,
+{
+    /// Records the current shielded pool anchor if the commitment tree changed this block.
+    pub(in crate::execution) fn record_shielded_pool_anchor_if_changed(
+        &self,
+        block_height: u64,
+        transaction: &Transaction,
+        platform_version: &PlatformVersion,
+    ) -> Result<(), Error> {
+        match platform_version
+            .drive_abci
+            .methods
+            .block_end
+            .record_shielded_pool_anchor
+        {
+            None => Ok(()),
+            Some(0) => self.record_shielded_pool_anchor_if_changed_v0(
+                block_height,
+                transaction,
+                platform_version,
+            ),
+            Some(version) => Err(Error::Execution(ExecutionError::UnknownVersionMismatch {
+                method: "record_shielded_pool_anchor_if_changed".to_string(),
+                known_versions: vec![0],
+                received: version,
+            })),
+        }
+    }
+}

packages/rs-drive-abci/src/execution/platform_events/block_processing_end_events/record_shielded_pool_anchor/mod.rs

@@ -0,0 +1,27 @@
+use crate::error::Error;
+use crate::platform_types::platform::Platform;
+use crate::rpc::core::CoreRPCLike;
+use dpp::version::PlatformVersion;
+use drive::grovedb::Transaction;
+
+impl<C> Platform<C>
+where
+    C: CoreRPCLike,
+{
+    /// Records the current shielded pool anchor if the commitment tree changed this block.
+    ///
+    /// Delegates to `Drive::record_shielded_pool_anchor_if_changed` which handles
+    /// all GroveDB operations: reading the current and most recent anchors, and
+    /// conditionally writing to the anchors tree, anchors-by-height tree, and
+    /// most recent anchor item.
+    pub(super) fn record_shielded_pool_anchor_if_changed_v0(
+        &self,
+        block_height: u64,
+        transaction: &Transaction,
+        platform_version: &PlatformVersion,
+    ) -> Result<(), Error> {
+        self.drive
+            .record_shielded_pool_anchor_if_changed(block_height, transaction, platform_version)
+            .map_err(Error::Drive)
+    }
+}