fix(dpp): restore the shipped order of basic consensus errors (#5053)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Author: QuantumExplorer

packages/rs-dpp/src/errors/consensus/basic/basic_error.rs

@@ -628,10 +628,6 @@ pub enum BasicError {
         InvalidTokenDistributionTimeIntervalNotMinuteAlignedError,
     ),
 
-    #[error(transparent)]
-    InvalidTokenDistributionEpochIntervalTooShortError(
-        InvalidTokenDistributionEpochIntervalTooShortError,
-    ),
     #[error(transparent)]
     RedundantDocumentPaidForByTokenWithContractId(RedundantDocumentPaidForByTokenWithContractId),
 
@@ -831,6 +827,14 @@ pub enum BasicError {
     // A document breaking a rule of its type's `propertyConstraints` (protocol version 14).
     #[error(transparent)]
     DocumentPropertyConstraintViolatedError(DocumentPropertyConstraintViolatedError),
+
+    // A perpetual distribution with a zero epoch interval (protocol version 14). Appended here:
+    // it was first inserted mid-enum, which shifted the discriminant of every variant shipped
+    // after it in 4.1.
+    #[error(transparent)]
+    InvalidTokenDistributionEpochIntervalTooShortError(
+        InvalidTokenDistributionEpochIntervalTooShortError,
+    ),
 }
 
 impl From<BasicError> for ConsensusError {
@@ -865,7 +869,7 @@ mod tests {
             discriminant_of(BasicError::IdentityKeyLimitsUpdateEmptyError(
                 IdentityKeyLimitsUpdateEmptyError::new(1)
             )),
-            186
+            185
         );
         // Once-per-identity token distribution (protocol version 14).
         assert_eq!(
@@ -874,47 +878,47 @@ mod tests {
                     InvalidTokenOncePerIdentityDistributionAmountError::new(0, 1)
                 )
             ),
-            187
+            186
         );
         // Pre-programmed distribution amounts (protocol version 14).
         assert_eq!(
             discriminant_of(BasicError::PreProgrammedDistributionAmountOverLimitError(
                 PreProgrammedDistributionAmountOverLimitError::new(0, 100)
             )),
-            188
+            187
         );
         // Contract moderation (protocol version 14).
         assert_eq!(
             discriminant_of(BasicError::InvalidContractModerationConfigError(
                 InvalidContractModerationConfigError::new("reason".to_string())
             )),
-            189
+            188
         );
         assert_eq!(
             discriminant_of(BasicError::ContractModerationSelfTargetError(
                 ContractModerationSelfTargetError::new(Identifier::from([1; 32]))
             )),
-            190
+            189
         );
         assert_eq!(
             discriminant_of(BasicError::ContractModerationReasonTooLongError(
                 ContractModerationReasonTooLongError::new(1025, 1024)
             )),
-            191
+            190
         );
         // Document action fees (protocol version 14).
         assert_eq!(
             discriminant_of(BasicError::DocumentActionFeesWithoutModerationError(
                 DocumentActionFeesWithoutModerationError::new("post".to_string())
             )),
-            192
+            191
         );
         // Documents cited by a contract moderation reason (protocol version 14).
         assert_eq!(
             discriminant_of(BasicError::InvalidContractModerationReasonDocumentsError(
                 InvalidContractModerationReasonDocumentsError::new("x".to_string())
             )),
-            193
+            192
         );
         // A `distinctFrom` identifier property equal to what it must differ from (protocol
         // version 14).
@@ -926,7 +930,7 @@ mod tests {
                     "$ownerId".to_string(),
                 )
             )),
-            194
+            193
         );
         // The shape of an `encryptedFor` property's ciphertext (protocol version 14).
         assert_eq!(
@@ -939,7 +943,7 @@ mod tests {
                     16
                 )
             )),
-            195
+            194
         );
         // Moderation charters (protocol version 14).
         assert_eq!(
@@ -949,20 +953,20 @@ mod tests {
                     "reason".to_string()
                 )
             )),
-            196
+            195
         );
         assert_eq!(
             discriminant_of(BasicError::ModerationCharterRewardSplitNotOneHundredError(
                 ModerationCharterRewardSplitNotOneHundredError::new(10, 40, 40)
             )),
-            197
+            196
         );
         // A string over its property's `maxBytes` (protocol version 14).
         assert_eq!(
             discriminant_of(BasicError::DocumentPropertyMaxBytesExceededError(
                 DocumentPropertyMaxBytesExceededError::new("description".to_string(), 4097, 4096)
             )),
-            198
+            197
         );
         // A document breaking a rule of its type's `propertyConstraints` (protocol version 14).
         assert_eq!(
@@ -973,7 +977,36 @@ mod tests {
                     PropertyConstraintViolation::NotMet,
                 )
             )),
+            198
+        );
+        // A perpetual distribution with a zero epoch interval (protocol version 14).
+        assert_eq!(
+            discriminant_of(
+                BasicError::InvalidTokenDistributionEpochIntervalTooShortError(
+                    InvalidTokenDistributionEpochIntervalTooShortError::new(0)
+                )
+            ),
             199
         );
     }
+
+    /// The variants that shipped in 4.1 keep the discriminants they were released with, so an
+    /// SDK built against 4.1 decodes the errors of a newer node as the same variants. A variant
+    /// inserted anywhere before the tail moves these and fails this test.
+    #[test]
+    fn should_keep_the_discriminants_shipped_in_4_1() {
+        assert_eq!(
+            discriminant_of(BasicError::RedundantDocumentPaidForByTokenWithContractId(
+                RedundantDocumentPaidForByTokenWithContractId::new(Identifier::from([1; 32]))
+            )),
+            140
+        );
+        // The last variant released in 4.1.
+        assert_eq!(
+            discriminant_of(BasicError::TokenPricingScheduleEmptyError(
+                TokenPricingScheduleEmptyError::new(Identifier::from([1; 32]))
+            )),
+            172
+        );
+    }
 }