feat(qt): DashPay opt-in, privacy gating and Platform network checks

Add the DashPay tab (behind the Show DashPay Tab option, default off) with the per-wallet opt-in it needs before anything contacts Platform. The opt-in dialog says the wallet connects to Dash Platform through evonodes and what the evonode answering each request can see (your IP address, or your proxy's; your identity and what it looks up; the usernames you search for), that connections are encrypted and use the same network settings and proxy as the rest of Dash Core, and that usernames, profiles and contact requests are public. It writes only the platform/enabled record and the record layout version.

PlatformPage::maybeCreateService constructs the PlatformService only when the wallet opted in, is a descriptor wallet holding its own keys, the node's network settings leave DashPay a network to use, network activity is on and the node has a ChainLock; otherwise the page shows the reason. There is no per-network gate: every network names a Platform LLMQ type, and on one without evonodes there are no endpoints to push, so nothing is sent. DashPay connects to evonodes as Core connects to its peers (PlatformRoute): with IPv4 or IPv6 reachable, through -proxy or directly, to evonodes on those networks, and to onion ones only when the onion proxy is that same proxy; with only onion reachable (-onlynet=onion), through the onion proxy to onion evonodes; never to I2P or CJDNS ones. The reachable networks come from interfaces::Node::isReachable and the proxies from getProxy, so -onion, -noonion and the Tor controller's onion proxy count, not -onlynet alone. The route is chosen once when the service is created, its proxy configures the client, and only evonodes on it are pushed; when the masternode list has evonodes but none on the route, nothing is pushed and the page says no evonode can be reached over the networks the settings allow. The service pushes an empty endpoint set while network activity is off, feeds evonode endpoints, Platform quorum keys and the best ChainLock height into the client on a timer and on every NotifyChainLock, and mints the SigningOperation every write signs under, which needs a wallet unlock that is released with the operation. Every client status passes through the service: an UnsupportedProtocolVersion freezes writes.

WalletModel::UnlockContext becomes movable so an operation can own it. After this commit the tab shows only the opt-in state; usernames, contacts and payments follow.

Tests (test_dash-qt PlatformTests over FakePlatformClient): no service and no client with the opt-in off; with no network DashPay can use the service is refused with a reason, while a proxy is no gate; the route for Core's defaults, -proxy, -proxy with -onion or -noonion, a Unix socket proxy, -onlynet=ipv4 and -onlynet=onion with and without an onion proxy, never reaching I2P, and read from the node's reachable networks (routeSelection); evonodes off the route not pushed and reported until one on it is (endpointsOffTheRouteAreNotPushed); the opt-in text names evonodes and the proxy and not other people or a proxy left unused (optInDisclosureCopy); an inactive network pushes an empty endpoint set; opting out wipes every record; every failure kind has a user-visible description and OK/AlreadyExists have none.

The welcome panel is a centred column between stretches rather than an aligned widget, so wrapped text gets the height its width needs, and a card whose text changes is measured again. The service pushes endpoints again as soon as network activity is back and reports when endpoints return (endpointsAvailable) and when network activity changes. A context change that comes while the endpoints are being collected (network activity turned off or on again quickly) has them collected again when that collection lands, not at the next timer tick, and the collection made before the change is dropped rather than pushed, so a set gathered while network activity was on never reaches the client after it was turned off. A message line can show a message that clears itself after a few seconds, and Show details text is built from the failed step's operation, status and time. Headings use the Overview page's section size. Test: network activity off empties the client's endpoints, turning it on pushes them again at once, a quick off and on collects them again, and a quick on and off pushes only the empty set (networkResumePushesEndpointsAgain).

The page is built from shared DashPay building blocks (qt/platform/platformui): the masternode dialogs' secondary-button style, busy bar and hints, and a message line with a Show details / Copy details disclosure. A failed Platform call is described in plain sentences mapped from its status kind and rs-dpp consensus code; the raw result is only in the details. A page that cannot start names what resolves it (Turn network on) or, for network settings, says what DashPay needs. Test: status descriptions are sentences without codes or internal messages, with the result in the details.

DashPay is turned on and off in Options, Wallet, in a DashPay group for the wallet the main window shows (DashPayOptionsWidget). Opting in is a per-wallet record, not a global setting, so the group names the wallet, says each wallet has its own setting, and its Enable DashPay… or Disable DashPay… acts at once through the opt-in or a confirmation whose default is Cancel and whose destructive button is secondary, like Reset Options, never through the dialog's OK or Cancel. The DashPay tab has no Disable button: where DashPay is on but not working, the welcome page offers DashPay settings…, which opens that group. The Show DashPay Tab tooltip says hiding the tab does not turn DashPay off. Test: the group turns DashPay on through the opt-in and off through the confirmation, Cancel changes nothing, and the tab offers no Disable button (dashPayOptionsSection).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Author: PastaPastaPasta

.gitignore

@@ -53,6 +53,7 @@ share/qt/Info.plist
 
 src/qt/*.moc
 src/qt/moc_*.cpp
+src/qt/platform/moc_*.cpp
 src/qt/forms/ui_*.h
 
 src/qt/test/moc*.cpp

src/Makefile.qt.include

@@ -122,6 +122,15 @@ QT_MOC_CPP = \
   qt/moc_walletmodel.cpp \
   qt/moc_walletview.cpp
 
+if ENABLE_PLATFORM_GUI
+QT_MOC_CPP += \
+  qt/platform/moc_dashpayoptionswidget.cpp \
+  qt/platform/moc_platformoptindialog.cpp \
+  qt/platform/moc_platformpage.cpp \
+  qt/platform/moc_platformservice.cpp \
+  qt/platform/moc_platformui.cpp
+endif
+
 BITCOIN_MM = \
   qt/macdockiconhandler.mm \
   qt/macnotificationhandler.mm \
@@ -224,6 +233,15 @@ BITCOIN_QT_H = \
   qt/walletview.h \
   qt/winshutdownmonitor.h
 
+if ENABLE_PLATFORM_GUI
+BITCOIN_QT_H += \
+  qt/platform/dashpayoptionswidget.h \
+  qt/platform/platformoptindialog.h \
+  qt/platform/platformpage.h \
+  qt/platform/platformservice.h \
+  qt/platform/platformui.h
+endif
+
 QT_RES_ICONS = \
   qt/res/icons/address-book.png \
   qt/res/icons/connect1_16.png \
@@ -357,12 +375,22 @@ BITCOIN_QT_WALLET_CPP = \
   qt/walletmodeltransaction.cpp \
   qt/walletview.cpp
 
+BITCOIN_QT_PLATFORM_CPP = \
+  qt/platform/dashpayoptionswidget.cpp \
+  qt/platform/platformoptindialog.cpp \
+  qt/platform/platformpage.cpp \
+  qt/platform/platformservice.cpp \
+  qt/platform/platformui.cpp
+
 BITCOIN_QT_CPP = $(BITCOIN_QT_BASE_CPP)
 if TARGET_WINDOWS
 BITCOIN_QT_CPP += $(BITCOIN_QT_WINDOWS_CPP)
 endif
 if ENABLE_WALLET
 BITCOIN_QT_CPP += $(BITCOIN_QT_WALLET_CPP)
+if ENABLE_PLATFORM_GUI
+BITCOIN_QT_CPP += $(BITCOIN_QT_PLATFORM_CPP)
+endif # ENABLE_PLATFORM_GUI
 endif # ENABLE_WALLET
 
 QT_RES_IMAGES = \
@@ -521,7 +549,7 @@ $(srcdir)/qt/dashstrings.cpp: FORCE
 
 # The resulted dash_en.xlf source file should follow Transifex requirements.
 # See: https://docs.transifex.com/formats/xliff#how-to-distinguish-between-a-source-file-and-a-translation-file
-translate: $(srcdir)/qt/dashstrings.cpp $(QT_FORMS_UI) $(QT_FORMS_UI) $(BITCOIN_QT_BASE_CPP) qt/bitcoin.cpp $(BITCOIN_QT_WINDOWS_CPP) $(BITCOIN_QT_WALLET_CPP) $(BITCOIN_QT_H) $(BITCOIN_MM)
+translate: $(srcdir)/qt/dashstrings.cpp $(QT_FORMS_UI) $(QT_FORMS_UI) $(BITCOIN_QT_BASE_CPP) qt/bitcoin.cpp $(BITCOIN_QT_WINDOWS_CPP) $(BITCOIN_QT_WALLET_CPP) $(BITCOIN_QT_PLATFORM_CPP) $(BITCOIN_QT_H) $(BITCOIN_MM)
 	@test -n $(LUPDATE) || echo "lupdate is required for updating translations"
 	$(AM_V_GEN) QT_SELECT=$(QT_SELECT) $(LUPDATE) -no-obsolete -I $(srcdir) -locations relative $^ -ts $(srcdir)/qt/locale/dash_en.ts
 	@test -n $(LCONVERT) || echo "lconvert is required for updating translations"
@@ -557,6 +585,7 @@ ui_%.h: %.ui
 	$(AM_V_GEN) QT_SELECT=$(QT_SELECT) $(MOC) $(DEFAULT_INCLUDES) $(QT_INCLUDES_UNSUPPRESSED) $(MOC_DEFS) $< > $@
 
 moc_%.cpp: %.h
+	@$(MKDIR_P) $(@D)
 	$(AM_V_GEN) QT_SELECT=$(QT_SELECT) $(MOC) $(DEFAULT_INCLUDES) $(QT_INCLUDES_UNSUPPRESSED) $(MOC_DEFS) $< > $@
 
 %.qm: %.ts

src/Makefile.qttest.include

@@ -25,6 +25,9 @@ TEST_QT_MOC_CPP += \
   qt/test/moc_sharedmnwidgettests.cpp \
   qt/test/moc_sharedmnwizardtests.cpp \
   qt/test/moc_wallettests.cpp
+if ENABLE_PLATFORM_GUI
+TEST_QT_MOC_CPP += qt/test/moc_platformtests.cpp
+endif
 endif # ENABLE_WALLET
 
 TEST_QT_H = \
@@ -35,6 +38,7 @@ TEST_QT_H = \
   qt/test/masternodetestutil.h \
   qt/test/masternodewidgettests.h \
   qt/test/optiontests.h \
+  qt/test/platformtests.h \
   qt/test/proposalvotetests.h \
   qt/test/providertransactiontests.h \
   qt/test/rpcnestedtests.h \
@@ -73,6 +77,9 @@ qt_test_test_dash_qt_SOURCES += \
   qt/test/sharedmnwizardtests.cpp \
   qt/test/wallettests.cpp \
   wallet/test/wallet_test_fixture.cpp
+if ENABLE_PLATFORM_GUI
+qt_test_test_dash_qt_SOURCES += qt/test/platformtests.cpp
+endif
 endif # ENABLE_WALLET
 
 nodist_qt_test_test_dash_qt_SOURCES = $(TEST_QT_MOC_CPP)

src/qt/bitcoingui.cpp

@@ -32,6 +32,9 @@
 #include <qt/openuridialog.h>
 #include <qt/optionsdialog.h>
 #include <qt/optionsmodel.h>
+#ifdef ENABLE_PLATFORM_GUI
+#include <qt/platform/dashpayoptionswidget.h>
+#endif
 #include <qt/proposallist.h>
 #include <qt/rpcconsole.h>
 #include <qt/utilitydialog.h>
@@ -775,6 +778,13 @@ void BitcoinGUI::createToolBars()
         coinJoinCoinsButton->setStatusTip(coinJoinCoinsAction->statusTip());
         tabGroup->addButton(coinJoinCoinsButton);
 
+#ifdef ENABLE_PLATFORM_GUI
+        platformButton = new QToolButton(this);
+        platformButton->setText(tr("&DashPay"));
+        platformButton->setStatusTip(tr("Usernames, profiles and contacts on Dash Platform"));
+        tabGroup->addButton(platformButton);
+#endif
+
         masternodeButton = new QToolButton(this);
         masternodeButton->setText(tr("&Masternodes"));
         masternodeButton->setStatusTip(tr("Browse masternodes"));
@@ -792,6 +802,9 @@ void BitcoinGUI::createToolBars()
         connect(historyButton, &QToolButton::clicked, this, &BitcoinGUI::gotoHistoryPage);
         connect(governanceButton, &QToolButton::clicked, this, &BitcoinGUI::gotoGovernancePage);
         connect(masternodeButton, &QToolButton::clicked, this, &BitcoinGUI::gotoMasternodePage);
+#ifdef ENABLE_PLATFORM_GUI
+        connect(platformButton, &QToolButton::clicked, this, &BitcoinGUI::gotoPlatformPage);
+#endif
 
         // Give the selected tab button a bolder font.
         connect(tabGroup, qOverload<QAbstractButton *, bool>(&QButtonGroup::buttonToggled), this, &BitcoinGUI::highlightTabButton);
@@ -805,6 +818,9 @@ void BitcoinGUI::createToolBars()
             if (button == coinJoinCoinsButton) { m_coinjoin_action = action; }
             else if (button == governanceButton) { m_governance_action = action; }
             else if (button == masternodeButton) { m_masternode_action = action; }
+#ifdef ENABLE_PLATFORM_GUI
+            else if (button == platformButton) { m_platform_action = action; }
+#endif
         }
 
         overviewButton->setChecked(true);
@@ -931,6 +947,9 @@ void BitcoinGUI::setClientModel(ClientModel *_clientModel, interfaces::BlockAndH
             connect(optionsModel, &OptionsModel::showGovernanceChanged, this, &BitcoinGUI::updateGovernanceVisibility);
             connect(optionsModel, &OptionsModel::showGovernanceClockChanged, this, &BitcoinGUI::updateGovernanceCycleIcon);
             connect(optionsModel, &OptionsModel::showMasternodesChanged, this, &BitcoinGUI::updateMasternodesVisibility);
+#ifdef ENABLE_PLATFORM_GUI
+            connect(optionsModel, &OptionsModel::showPlatformChanged, this, &BitcoinGUI::updatePlatformVisibility);
+#endif
 
             if (trayIcon) {
                 // be aware of the tray icon disable state change reported by the OptionsModel object.
@@ -968,6 +987,9 @@ void BitcoinGUI::setClientModel(ClientModel *_clientModel, interfaces::BlockAndH
     updateCoinJoinVisibility();
     updateGovernanceVisibility();
     updateMasternodesVisibility();
+#ifdef ENABLE_PLATFORM_GUI
+    updatePlatformVisibility();
+#endif
 }
 
 #ifdef ENABLE_WALLET
@@ -1023,6 +1045,10 @@ void BitcoinGUI::addWallet(WalletModel* walletModel)
     });
     connect(wallet_view, &WalletView::encryptionStatusChanged, this, &BitcoinGUI::updateWalletStatus);
     connect(wallet_view, &WalletView::incomingTransaction, this, &BitcoinGUI::incomingTransaction);
+#ifdef ENABLE_PLATFORM_GUI
+    connect(wallet_view, &WalletView::dashPaySettingsRequested, this,
+            [this] { openOptionsDialogWithTab(OptionsDialog::TAB_WALLET); });
+#endif
     connect(wallet_view, &WalletView::showProposalInfo, this, [this] {
         rpcConsole->setInfoView(RPCConsole::InfoView::Governance);
         showDebugWindow();
@@ -1341,6 +1367,16 @@ void BitcoinGUI::gotoMasternodePage()
     }
 }
 
+#ifdef ENABLE_PLATFORM_GUI
+void BitcoinGUI::gotoPlatformPage()
+{
+    if (platformButton) {
+        platformButton->setChecked(true);
+        if (walletFrame) walletFrame->gotoPlatformPage();
+    }
+}
+#endif
+
 void BitcoinGUI::gotoReceiveCoinsPage()
 {
     receiveCoinsButton->setChecked(true);
@@ -1490,6 +1526,13 @@ void BitcoinGUI::openOptionsDialogWithTab(OptionsDialog::Tab tab)
     dlg->setCurrentTab(tab);
     dlg->setClientModel(clientModel);
     dlg->setModel(clientModel->getOptionsModel());
+#ifdef ENABLE_PLATFORM_GUI
+    // DashPay is turned on and off per wallet: the section is for the wallet
+    // the window shows, which cannot change while the dialog is open.
+    if (WalletView* view{walletFrame ? walletFrame->currentWalletView() : nullptr}; view && view->getPlatformPage()) {
+        dlg->addWalletSection(new DashPayOptionsWidget(*view->getPlatformPage(), *view->getWalletModel(), dlg));
+    }
+#endif
     connect(dlg, &OptionsDialog::appearanceChanged, [this]() {
         updateWidth();
     });
@@ -1577,6 +1620,29 @@ void BitcoinGUI::updateMasternodesVisibility()
     updateWidth();
 }
 
+#ifdef ENABLE_PLATFORM_GUI
+void BitcoinGUI::updatePlatformVisibility()
+{
+    if (!clientModel || !clientModel->getOptionsModel()) return;
+    const bool fShow = clientModel->getOptionsModel()->getShowPlatformTab();
+
+    // Show/hide the underlying QAction, hiding the QToolButton itself doesn't
+    // work for the GUI part but is still needed for shortcuts to work properly.
+    if (m_platform_action) m_platform_action->setVisible(fShow);
+    if (platformButton) {
+#ifdef ENABLE_WALLET
+        if (!fShow && platformButton->isChecked()) {
+            gotoOverviewPage();
+        }
+#endif // ENABLE_WALLET
+        platformButton->setVisible(fShow);
+    }
+
+    GUIUtil::updateButtonGroupShortcuts(tabGroup);
+    updateWidth();
+}
+#endif // ENABLE_PLATFORM_GUI
+
 void BitcoinGUI::updateWidth()
 {
     if (walletFrame == nullptr) {

src/qt/bitcoingui.h

@@ -143,6 +143,9 @@ class BitcoinGUI : public QMainWindow
     QToolButton* historyButton = nullptr;
     QToolButton* masternodeButton = nullptr;
     QToolButton* governanceButton = nullptr;
+#ifdef ENABLE_PLATFORM_GUI
+    QToolButton* platformButton = nullptr;
+#endif
     QAction* appToolBarLogoAction = nullptr;
     QAction* quitAction = nullptr;
     QAction* sendCoinsAction = nullptr;
@@ -154,6 +157,9 @@ class BitcoinGUI : public QMainWindow
     QAction* m_coinjoin_action = nullptr;
     QAction* m_governance_action = nullptr;
     QAction* m_masternode_action = nullptr;
+#ifdef ENABLE_PLATFORM_GUI
+    QAction* m_platform_action = nullptr;
+#endif
     QAction* m_load_psbt_action = nullptr;
     QAction* m_load_psbt_clipboard_action = nullptr;
     QAction* aboutAction = nullptr;
@@ -356,6 +362,10 @@ public Q_SLOTS:
     void gotoHistoryPage();
     /** Switch to masternode page */
     void gotoMasternodePage();
+#ifdef ENABLE_PLATFORM_GUI
+    /** Switch to DashPay (Dash Platform) page */
+    void gotoPlatformPage();
+#endif
     /** Switch to receive coins page */
     void gotoReceiveCoinsPage();
     /** Switch to send coins page */
@@ -417,6 +427,9 @@ public Q_SLOTS:
     void updateCoinJoinVisibility();
     void updateGovernanceVisibility();
     void updateMasternodesVisibility();
+#ifdef ENABLE_PLATFORM_GUI
+    void updatePlatformVisibility();
+#endif
 
     void updateWidth();
 };

src/qt/forms/optionsdialog.ui

@@ -1080,6 +1080,16 @@ https://explore.transifex.com/dash/dash/</string>
          </property>
         </widget>
        </item>
+       <item>
+        <widget class="QCheckBox" name="showPlatformTab">
+         <property name="toolTip">
+          <string>Show additional tab for DashPay usernames, profiles and contacts on Dash Platform. Hiding the tab doesn't turn DashPay off; use Wallet → DashPay for that.</string>
+         </property>
+         <property name="text">
+          <string>Show DashPay Tab</string>
+         </property>
+        </widget>
+       </item>
        <item>
         <widget class="QCheckBox" name="showGovernanceTab">
          <property name="toolTip">

src/qt/optionsdialog.cpp

@@ -111,6 +111,9 @@ OptionsDialog::OptionsDialog(QWidget* parent, bool enableWallet)
 
     pageButtons = new QButtonGroup(this);
     pageButtons->addButton(ui->btnMain, pageButtons->buttons().size());
+#ifndef ENABLE_PLATFORM_GUI
+    ui->showPlatformTab->hide();
+#endif
     /* Remove Wallet/CoinJoin tabs and 3rd party-URL textbox in case of -disablewallet */
     if (!m_enable_wallet) {
         ui->stackedWidgetOptions->removeWidget(ui->pageWallet);
@@ -120,6 +123,7 @@ OptionsDialog::OptionsDialog(QWidget* parent, bool enableWallet)
         ui->thirdPartyTxUrlsLabel->setVisible(false);
         ui->thirdPartyTxUrls->setVisible(false);
         ui->showMasternodesTab->hide();
+        ui->showPlatformTab->hide();
         ui->showGovernanceTab->hide();
         ui->showGovernanceCycleIcon->hide();
     } else {
@@ -342,6 +346,12 @@ void OptionsDialog::setCurrentTab(OptionsDialog::Tab tab)
     showPage(std23::to_underlying(tab));
 }
 
+void OptionsDialog::addWalletSection(QWidget* section)
+{
+    // Above the spacer that keeps the page's content at the top.
+    ui->verticalLayout_Wallet->insertWidget(ui->verticalLayout_Wallet->count() - 1, section);
+}
+
 void OptionsDialog::setMapper()
 {
     /* Main */
@@ -394,6 +404,9 @@ void OptionsDialog::setMapper()
 
     /* Display */
     mapper->addMapping(ui->showMasternodesTab, OptionsModel::ShowMasternodesTab);
+#ifdef ENABLE_PLATFORM_GUI
+    mapper->addMapping(ui->showPlatformTab, OptionsModel::ShowPlatformTab);
+#endif
     mapper->addMapping(ui->showGovernanceCycleIcon, OptionsModel::ShowGovernanceClock);
     mapper->addMapping(ui->showGovernanceTab, OptionsModel::ShowGovernanceTab);
     mapper->addMapping(ui->digits, OptionsModel::Digits);

src/qt/optionsdialog.h

@@ -56,6 +56,9 @@ class OptionsDialog : public QDialog
     void setModel(OptionsModel *model);
     void setMapper();
     void setCurrentTab(OptionsDialog::Tab tab);
+    //! Add a section to the end of the Wallet page (the current wallet's
+    //! DashPay setting).
+    void addWalletSection(QWidget* section);
 
 private Q_SLOTS:
     /** custom tab buttons clicked */

src/qt/optionsmodel.cpp

@@ -324,6 +324,10 @@ bool OptionsModel::Init(bilingual_str& error)
         settings.setValue("fShowMasternodesTab", false);
     m_enable_masternodes = settings.value("fShowMasternodesTab", false).toBool();
 
+    if (!settings.contains("fShowPlatformTab"))
+        settings.setValue("fShowPlatformTab", false);
+    m_enable_platform = settings.value("fShowPlatformTab", false).toBool();
+
     if (!settings.contains("show_governance_clock"))
         settings.setValue("show_governance_clock", false);
     m_show_governance_clock = settings.value("show_governance_clock", false).toBool();
@@ -660,6 +664,8 @@ QVariant OptionsModel::getOption(OptionID option, const std::string& suffix) con
         return m_sub_fee_from_amount;
     case ShowMasternodesTab:
         return m_enable_masternodes;
+    case ShowPlatformTab:
+        return m_enable_platform;
     case ShowGovernanceClock:
         return m_show_governance_clock;
     case ShowGovernanceTab:
@@ -861,6 +867,13 @@ bool OptionsModel::setOption(OptionID option, const QVariant& value, const std::
             Q_EMIT showMasternodesChanged();
         }
         break;
+    case ShowPlatformTab:
+        if (changed()) {
+            m_enable_platform = value.toBool();
+            settings.setValue("fShowPlatformTab", m_enable_platform);
+            Q_EMIT showPlatformChanged();
+        }
+        break;
     case SubFeeFromAmount:
         m_sub_fee_from_amount = value.toBool();
         settings.setValue("SubFeeFromAmount", m_sub_fee_from_amount);