Repository navigation
Commit 06582cd
committed
b201f1f Merge bitcoin#27892: refactor: Avoid copy of bilingual_str when formatting, Fix ADL violation (DCG-Claude)
7286cbc Merge bitcoin#23813: Add test and docs for getblockfrompeer with pruning (DCG-Claude)
98b9304 Merge bitcoin#27425: test: move remaining rand code from util/setup_common to util/random (DCG-Claude)
b539c3d Merge bitcoin#27549: fuzz: addrman, add coverage for `network` field in `Select()`, `Size()` and `GetAddr()` (DCG-Claude)
Pull request description:
<!-- backportsys v1 -->
## Issue being fixed or feature implemented
Backports 4 Bitcoin Core v0.26 pull request(s) that the Dash queue selected, including any discovered prerequisites: bitcoin#27549, bitcoin#27425, bitcoin#23813, bitcoin#27892.
## What was done?
| upstream | commit | gates | notes |
|---|---|---|---|
| bitcoin#27549 | `8787b4a5bf` | build:pass mech:warn pick:pass tests:pass tree:pass verify:pass | The commit is a faithful backport of bitcoin#27549: the fuzz target now picks an optional `Network` fr |
| bitcoin#27425 | `53d9fa22f9` | build:pass mech:warn pick:pass tests:pass tree:pass verify:pass | Faithful replay of bitcoin#27425: the g_insecure_rand_ctx global, Seed()/GetUintFromEnv() and the Seed |
| bitcoin#23813 | `479e797f80` | build:pass mech:warn pick:pass tests:pass tree:pass verify:pass | The RPC help-text change is applied verbatim and the functional test reproduces every upstream hunk, with prun |
| bitcoin#27892 | `9561488e92` | build:pass ci_fork:pass mech:warn pick:pass tests:pass tree:pass verify:pass | The commit replaces the two TranslateArg overloads in src/util/translation.h with the generic-lambda `translat |
Each commit keeps the upstream subject (`partial Merge …` only where a hunk is deferred to a prerequisite still to be backported, named in the commit body; a hunk Dash intentionally never wants is recorded in the commit body or the reviewer's note above and does not make the backport partial). Conflicts were resolved commit by commit; commits that needed no resolution were cherry-picked unchanged.
## How Has This Been Tested?
Recorded per commit, at that commit's own sha, not once for the branch:
- built at each commit, reusing the worktree build cache
- the test suites touched by each diff run at that commit, where the diff selected one
- a mechanical diff-of-diffs against the upstream patch (every upstream hunk present, no added line without an upstream counterpart, no Dash-specific line dropped)
- an independent verification pass on 4 commit(s) that needed adaptation
- CI green on the fork gate PR thepastaclaw#67 at `9561488e92`, which is this branch's head
Gates that did not come back clean — please weigh these:
- bitcoin#27549 `mech`: **warn** — 1 invented line(s); 1 partial/prereq/low-risk finding(s)
- bitcoin#27425 `mech`: **warn** — 1 partial/prereq/low-risk finding(s)
- bitcoin#23813 `mech`: **warn** — 19 invented line(s); 1 partial/prereq/low-risk finding(s)
- bitcoin#27892 `mech`: **warn** — 1 partial/prereq/low-risk finding(s)
## Breaking Changes
None beyond the upstream changes themselves.
## Checklist:
_Left for the reviewer; backportsys does not tick boxes on its own behalf._
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have added or updated relevant unit/integration/functional/e2e tests
- [ ] I have made corresponding changes to the documentation
- [ ] I have assigned this pull request to a milestone
---
### Maintainer controls
<!-- backportsys controls -->
Tick a box and backportsys acts on it within a few minutes, then clears the box. For anything else — a hunk to drop, a resolution to redo, a question — just leave a review comment; nothing here needs a box.
- [ ] 🔒 **Hands off** — stop every automated update to this branch <!-- bps:hands_off -->
- [ ] 🔄 **Rebase** onto current `develop` <!-- bps:rebase -->
- [ ] ❌ **Close** — abandon this batch and release its items <!-- bps:close -->
<!-- /backportsys controls -->
<!-- human notes below; the bot never edits this section -->
Top commit has no ACKs.
Tree-SHA512: 228f702a1a7edad7195bb937d76f78b08d562ac32209d754aa105453ac62c224cc8088b70bd372c56d00f916e084a5f8140f4207b56226b2bc69152617a30360
15 files changed
Lines changed: 153 additions & 77 deletions
File tree
- src
- rpc
- test
- fuzz
- util
- util
- wallet/test
- test/functional
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
| 46 | + | |
46 | 47 | | |
47 | 48 | | |
48 | 49 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
488 | 488 | | |
489 | 489 | | |
490 | 490 | | |
491 | | - | |
| 491 | + | |
| 492 | + | |
492 | 493 | | |
493 | 494 | | |
494 | 495 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| 16 | + | |
16 | 17 | | |
17 | 18 | | |
18 | 19 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
280 | 280 | | |
281 | 281 | | |
282 | 282 | | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
283 | 287 | | |
284 | | - | |
285 | | - | |
286 | | - | |
287 | | - | |
288 | | - | |
289 | | - | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
290 | 298 | | |
291 | 299 | | |
292 | 300 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
17 | 18 | | |
18 | 19 | | |
19 | 20 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| 7 | + | |
7 | 8 | | |
8 | 9 | | |
9 | 10 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
11 | 10 | | |
12 | 11 | | |
13 | 12 | | |
14 | 13 | | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
15 | 45 | | |
16 | 46 | | |
17 | 47 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| 43 | + | |
43 | 44 | | |
44 | 45 | | |
45 | 46 | | |
| |||
49 | 50 | | |
50 | 51 | | |
51 | 52 | | |
| 53 | + | |
52 | 54 | | |
53 | 55 | | |
54 | 56 | | |
| |||
105 | 107 | | |
106 | 108 | | |
107 | 109 | | |
108 | | - | |
109 | 110 | | |
110 | 111 | | |
111 | 112 | | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | | - | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | | - | |
122 | | - | |
123 | | - | |
124 | | - | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | 113 | | |
132 | 114 | | |
133 | 115 | | |
| |||
0 commit comments