Skip to content

Commit 442c88b

Browse files
chore(deps-actions): update github-actions (#266)
* chore(deps-actions): update github-actions * chore(ci): remove fragile ci-policy test and clarify TDD scope Delete ci-required.test.cjs and test-ci-policy job that pinned checkout SHA and broke on Renovate bumps. Clean dangling refs in ci-required validator and required gate. Add TDD YES/NO policy to AGENTS.md so config and Actions use light validation only. --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Yuniel Acosta Pérez <33158051+yacosta738@users.noreply.github.com>
1 parent fb1a423 commit 442c88b

15 files changed

Lines changed: 101 additions & 255 deletions

File tree

‎.agents/AGENTS.md‎

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -117,6 +117,23 @@ completion. Flaky SQLite tests may need an isolated re-run.
117117
- `just test-integration` — integration tests only
118118
- `just test-e2e` — Playwright suite (requires `just test-e2e-build` + Docker)
119119

120+
## Testing Policy — TDD Scope
121+
122+
TDD follows explicit project/session configuration, never by default.
123+
When enabled: failing test first, then RED → GREEN → REFACTOR.
124+
When disabled: ordinary functional checks only.
125+
126+
- **TDD YES** — pure domain logic: use-cases, classifiers, parsers,
127+
wire formats. Example: `issue-labeler.cjs classify()` invariants
128+
(no invented product, human preservation, idempotence).
129+
- **TDD NO** — config / YAML / GitHub Actions / Renovate-pinned SHAs,
130+
docs-only changes. Light validation only:
131+
`ruby -ryaml YAML.load_file`, `node --check`, smoke run.
132+
- **Anti-pattern** — asserting implementation details like
133+
`actions/checkout@<40-hex>` pinned SHA or path-filter literals.
134+
If a policy check is needed, use a non-fragile shape
135+
(e.g. `/uses:\s*actions\/checkout@[a-f0-9]{40}/`), never a literal SHA.
136+
120137
## References
121138

122139
- [Architecture](docs/architecture.md) — layer diagram, data/config flow

‎.agents/skills/testing/playwright-best-practices/.github/workflows/validate-skill.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
name: Agnix Lint
1212
runs-on: ubuntu-latest
1313
steps:
14-
- uses: actions/checkout@v4
14+
- uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4
1515

1616
- name: Validate agent configs
1717
uses: agent-sh/agnix@12a1917d13e7c804bc91768c30dd4159f536c5c6

‎.github/scripts/ci-required-run.cjs‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ const resultKeys = {
1717
'gitleaks-pr': 'GITLEAKS_PR',
1818
'semgrep-pr': 'SEMGREP_PR',
1919
sonar: 'SONAR',
20-
'test-ci-policy': 'TEST_CI_POLICY',
2120
};
2221
const outputKeys = {
2322
backend: 'CHANGES_BACKEND',

‎.github/scripts/ci-required.cjs‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
const EXPECTED = [
22
{ job: 'changes', when: () => true },
3-
{ job: 'test-ci-policy', when: (c) => c.github },
43
{ job: 'build-dashboard', when: (c) => c.backend || c.frontend || c.github },
54
{ job: 'fmt', when: (c) => c.backend || c.github },
65
{ job: 'markdown', when: (c) => c.docs || c.github },

‎.github/scripts/ci-required.test.cjs‎

Lines changed: 0 additions & 155 deletions
This file was deleted.

‎.github/workflows/cache-cleanup.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ permissions:
2323
jobs:
2424
cleanup:
2525
name: 🧹 Clean Caches
26-
uses: dallay/common-actions/.github/workflows/cache-maintenance.yml@v2.2.1
26+
uses: dallay/common-actions/.github/workflows/cache-maintenance.yml@69060250307677655136ca88c70a2f77cb4153b2 # v2.2.4
2727
with:
2828
retention-days: 7
2929
cache-types: ${{ inputs.cache-type || 'all' }}

0 commit comments

Comments
 (0)