review

Author: danmar

.github/workflows/CI-unixish-docker.yml

@@ -30,7 +30,7 @@ jobs:
           - image: "alpine:3.23"
             with_gui: false  # it appears FindQt6.cmake is not provided by any package
             full_build: false  # FIXME: test-signalhandler.cpp fails to build since feenableexcept() is missing
-          - image: "oraclelinux:8"
+          - image: "oraclelinux:8-slim"
             with_gui: false  # no qt6 are installed, missing GUI in old distros is OK
             full_build: true
       fail-fast: false # Prefer quick result
@@ -96,7 +96,7 @@ jobs:
 
     strategy:
       matrix:
-        image: ["ubuntu:24.04", "ubuntu:25.10", "alpine:3.23", "oraclelinux:8"]
+        image: ["ubuntu:24.04", "ubuntu:25.10", "alpine:3.23", "oraclelinux:8-slim"]
       fail-fast: false # Prefer quick result
 
     runs-on: ubuntu-22.04

lib/settings.h

@@ -97,9 +97,7 @@ class SimpleEnableGroup {
 #if defined(__GNUC__) && !defined(__clang__) && __GNUC__ <= 9
 // Hack to workaround GCC bug.
 // Details: https://trac.cppcheck.net/ticket/14850
-// seen on:
-// oraclelinux:8, g++-8.5
-// ubuntu:20.04, g++-9.4.0
+// seen on g++ before 10.x
 #define  CPPCHECK_NOEXCEPT
 #else
 #define  CPPCHECK_NOEXCEPT  noexcept