Repository navigation
[LOGS]: TestReadRotatedLog fails on windows #3554
Description
Description
=== RUN TestReadRotatedLog
cri_logger_test.go:285: failed to rotate log "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\TestReadRotatedLog3469684812\\001\\logfile2318891333" to "C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\TestReadRotatedLog3469684812\\001\\logfile2318891333.1620241016-014354", error: rename C:\Users\RUNNER~1\AppData\Local\Temp\TestReadRotatedLog3469684812\001\logfile2318891333 C:\Users\RUNNER~1\AppData\Local\Temp\TestReadRotatedLog3469684812\001\logfile2318891333.1620241016-014354: The process cannot access the file because it is being used by another process.
testing.go:1232: TempDir RemoveAll cleanup: remove C:\Users\RUNNER~1\AppData\Local\Temp\TestReadRotatedLog3469684812\001\logfile2318891333: The process cannot access the file because it is being used by another process.
--- FAIL: TestReadRotatedLog (2.05s)
Steps to reproduce the issue
Run unit tests for windows.
Describe the results you received and expected
This does not seem like a non-compatible test, but rather an actual issue?
I'll skip the test for the time being so that we can enable unit tests for windows, but this should be looked into?
What version of nerdctl are you using?
main
Are you using a variant of nerdctl? (e.g., Rancher Desktop)
None
Host information
No response
Activity
fahedouch commentedon Oct 16, 2024
it seems like the file is not closed correctly or cri is playing with the file, I think we can lock the file before processing the renaming operation
apostasie commentedon Oct 18, 2024
@fahedouch would you claim dibs on this?
Pretty sure a fix on this would significantly improve windows logs stability.
[-]TestReadRotatedLog fails on windows[/-][+][LOGS]: TestReadRotatedLog fails on windows[/+]fix(logging): open followed log files with FILE_SHARE_DELETE on Windows