Windows builds failing with `Path does not exist: D:\a\1\s\!ENV_ARTIFACT_PATH!`

[maresb]

Context: conda-forge/pytensor-suite-feedstock#170 (comment)

Windows builds are failing with

Path does not exist: D:\a\1\s\!ENV_ARTIFACT_PATH!

Note that due to frequent debugging needs, I have

azure:
  store_build_artifacts: true

I wonder if this is related to #2347

[h-vetinari]

I wonder if this is related to #2347

I could have sworn it had nothing to do with it, but against all expectations, the addition of

conda-smithy/conda_smithy/templates/create_conda_build_artifacts.bat.tmpl

Line 22 in 090c3f7

@echo on

is the cause of the breakage (well, if a print statement breaks something, arguably things were mighty fragile beforehand already, but well... Hyrum's law is relentless). See conda-forge/pytensor-suite-feedstock@c7c2743 in conda-forge/pytensor-suite-feedstock#171

[bdenhollander]

Might it have something to do with this line using ! to wrap the variable name

conda-smithy/conda_smithy/templates/create_conda_build_artifacts.bat.tmpl

Line 63 in 090c3f7

set ENV_ARTIFACT_NAME=!ENV_ARTIFACT_PREFIX!_%ARTIFACT_UNIQUE_ID%

while this line uses %?

conda-smithy/conda_smithy/templates/create_conda_build_artifacts.bat.tmpl

Line 43 in 090c3f7

set BLD_ARTIFACT_NAME=%BLD_ARTIFACT_PREFIX%_%ARTIFACT_UNIQUE_ID%

[askorikov]

I guess the problem is that this path should not normally get executed:

conda-smithy/conda_smithy/templates/create_conda_build_artifacts.bat.tmpl

Lines 62 to 78 in 090c3f7

	if defined ENV_ARTIFACT_PREFIX (
	set ENV_ARTIFACT_NAME=!ENV_ARTIFACT_PREFIX!_%ARTIFACT_UNIQUE_ID%
	echo ENV_ARTIFACT_NAME: !ENV_ARTIFACT_NAME!
	set "ENV_ARTIFACT_PATH=%ARTIFACT_STAGING_DIR%\%FEEDSTOCK_NAME%_%ENV_ARTIFACT_PREFIX%_%ARCHIVE_UNIQUE_ID%.zip"
	7z a "!ENV_ARTIFACT_PATH!" -r "%CONDA_BLD_DIR%"/_*_env*/ -bb
	if errorlevel 1 exit 1
	echo ENV_ARTIFACT_PATH: !ENV_ARTIFACT_PATH!
	if "%CI%" == "azure" (
	echo ##vso[task.setVariable variable=ENV_ARTIFACT_NAME]!ENV_ARTIFACT_NAME!
	echo ##vso[task.setVariable variable=ENV_ARTIFACT_PATH]!ENV_ARTIFACT_PATH!
	)
	if "%CI%" == "github_actions" (
	echo ENV_ARTIFACT_NAME=!ENV_ARTIFACT_NAME!>> !GITHUB_OUTPUT!
	echo ENV_ARTIFACT_PATH=!ENV_ARTIFACT_PATH!>> !GITHUB_OUTPUT!
	)

Can it be that the Azure command ##vso[task.setVariable variable=ENV_ARTIFACT_PATH]!ENV_ARTIFACT_PATH! gets executed as long as the script outputs it to stdout, so adding @echo on effectively makes it ignore the if defined logic?