From 94eb0c854756a490066d995d814d6f6c7e1a24e0 Mon Sep 17 00:00:00 2001 From: Smit Khobragade Date: Wed, 25 Dec 2024 20:24:23 +0530 Subject: [PATCH 1/3] Added more profile links - Email and Instagram --- CONTRIBUTING.md | 13 +++++-------- README.md | 4 +++- src/components/Profile/Profile.jsx | 14 +++++++++++++- src/components/ProfileSkeleton/ProfileSkeleton.jsx | 8 ++++++++ 4 files changed, 29 insertions(+), 10 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index e9542b3f..a169065c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -73,12 +73,7 @@ Starring the repository is a mandatory step for all contributors and the first p 7. **Add your JSON filename** (your_github_username.json) to the array of filenames in the ProfileList.json file, like this: ```json - [ - "filename1.json", - "filename2.json", - "filename3.json", - "your_github_username.json" - ] + ["filename1.json", "filename2.json", "filename3.json", "your_github_username.json"] ``` 8. **Save** the **`ProfileLists.json`** file. @@ -139,6 +134,7 @@ DEVDISPLAY/ ├── ├── tailwind.config.js ``` +

@@ -196,7 +192,7 @@ git push -u origin
Now Click Here For Installing The Node Packages 📩 -1. **Install dependencies** +11. **Install dependencies** Time to gather our supplies! Navigate to the project folder in your terminal and install the dependencies with these magical incantations: @@ -219,6 +215,7 @@ Before you reveal your wizardry, ensure everything works like a charm. Run the t ```bash npm test ``` +

@@ -262,7 +259,7 @@ npm test - Once you're satisfied, click the "Create pull request" button to submit your pull request. 9. **Wait for Review:** - Your pull request will now be available for review by the project maintainers. They may provide feedback or ask for changes before merging your pull request into the main branch of the project repository. +Your pull request will now be available for review by the project maintainers. They may provide feedback or ask for changes before merging your pull request into the main branch of the project repository.

diff --git a/README.md b/README.md index 3278695a..02080c13 100644 --- a/README.md +++ b/README.md @@ -201,7 +201,9 @@ "social": { "GitHub": "https://github.com/your-github-username", "Twitter": "https://twitter.com/your-twitter-username", - "LinkedIn": "https://www.linkedin.com/in/your-linkedin-username" + "LinkedIn": "https://www.linkedin.com/in/your-linkedin-username", + "Instagram": "https://www.instagram.com/your-insta-username/", + "Email": "youremail@gmail.com" } } ``` diff --git a/src/components/Profile/Profile.jsx b/src/components/Profile/Profile.jsx index d0ee962c..dfae5dc0 100644 --- a/src/components/Profile/Profile.jsx +++ b/src/components/Profile/Profile.jsx @@ -1,5 +1,5 @@ import React from 'react'; -import { FaGithub, FaLinkedin } from 'react-icons/fa'; +import { FaEnvelope, FaGithub, FaInstagram, FaLinkedin } from 'react-icons/fa'; import { FaXTwitter, FaLocationDot } from 'react-icons/fa6'; function Profile({ data }) { @@ -131,6 +131,18 @@ function Card({ data }) { )} + + {data.social?.Instagram && ( + + + + )} + + {data.social?.Email && ( + + + + )} diff --git a/src/components/ProfileSkeleton/ProfileSkeleton.jsx b/src/components/ProfileSkeleton/ProfileSkeleton.jsx index 24c15af1..c11fc05d 100644 --- a/src/components/ProfileSkeleton/ProfileSkeleton.jsx +++ b/src/components/ProfileSkeleton/ProfileSkeleton.jsx @@ -12,6 +12,8 @@ function ProfileSkeleton() { GitHub: '', Twitter: '', LinkedIn: '', + Instagram: '', + Email: '', }, }; @@ -50,6 +52,12 @@ function ProfileSkeleton() {
{skeletonData.social.GitHub}
+
+ {skeletonData.social.GitHub} +
+
+ {skeletonData.social.GitHub} +
From 51fdefdd4f07bb1321119b63beac27845cf7837a Mon Sep 17 00:00:00 2001 From: Ashutosh Singh <130897584+codeaashu@users.noreply.github.com> Date: Wed, 25 Dec 2024 20:44:37 +0530 Subject: [PATCH 2/3] Update CONTRIBUTING.md --- CONTRIBUTING.md | 33 ++++++++++++++++++--------------- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index cab583e1..5a8ee4d9 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -73,7 +73,12 @@ Starring the repository is a mandatory step for all contributors and the first p 7. **Add your JSON filename** (your_github_username.json) to the array of filenames in the ProfileList.json file, like this: ```json - ["filename1.json", "filename2.json", "filename3.json", "your_github_username.json"] + [ + "filename1.json", + "filename2.json", + "filename3.json", + "your_github_username.json" + ] ``` 8. **Save** the **`ProfileLists.json`** file. @@ -87,10 +92,10 @@ Starring the repository is a mandatory step for all contributors and the first p - +

Man Raising Hand Light Skin Tone Need Help Man Raising Hand Light Skin Tone

- Now Click Here For Need Help With The Basics? 🤔 + Click Here For Need Help With The Basics? 🤔 If you're new to Git and GitHub, no worries! Here are some useful resources: @@ -104,7 +109,7 @@ If you're new to Git and GitHub, no worries! Here are some useful resources:

- Now Click Here To View The Project Structure 📂 + Click Here To View The Project Structure 📂 ```bash DEVDISPLAY/ @@ -136,12 +141,11 @@ DEVDISPLAY/ ├── ├── tailwind.config.js ``` -

- Now Click Here For First Pull Request ✨ + Click Here For First Pull Request ✨ 1. **Star this repository** Click on the top right corner marked as **Stars** at last. @@ -192,9 +196,9 @@ git push -u origin

- Now Click Here For Installing The Node Packages 📩 + Click Here For Installing The Node Packages 📩 -11. **Install dependencies** +1. **Install dependencies** Time to gather our supplies! Navigate to the project folder in your terminal and install the dependencies with these magical incantations: @@ -217,12 +221,11 @@ Before you reveal your wizardry, ensure everything works like a charm. Run the t ```bash npm test ``` -

- Now Click Here For Contribute using GitHub Desktop 🖥️ + Click Here For Contribute using GitHub Desktop 🖥️ 1. **Open GitHub Desktop:** Launch GitHub Desktop and log in to your GitHub account if you haven't already. @@ -261,11 +264,10 @@ npm test - Once you're satisfied, click the "Create pull request" button to submit your pull request. 9. **Wait for Review:** -Your pull request will now be available for review by the project maintainers. They may provide feedback or ask for changes before merging your pull request into the main branch of the project repository. + Your pull request will now be available for review by the project maintainers. They may provide feedback or ask for changes before merging your pull request into the main branch of the project repository. +
+
- -
- # Pull Request Process Rocket @@ -287,7 +289,8 @@ To report an issue, follow these steps: 3. Provide a clear and concise description of the issue. 4. Wait until someone looks into your report. 5. Begin working on the issue only after you have been assigned to it. 🚀 - +

Clapping Hands We appreciate your support Love Letter Thank you for contributing Clapping Hands

+
Love Letter
From 5d50e84c9dcbdec962e227dd4b781c4f05a1eb3e Mon Sep 17 00:00:00 2001 From: Ashutosh Singh <130897584+codeaashu@users.noreply.github.com> Date: Wed, 25 Dec 2024 20:45:47 +0530 Subject: [PATCH 3/3] Update CONTRIBUTING.md