Skip to content

Commit f522d9f

Browse files
authored
Merge pull request #473 from Jordan08/dev-clean-v2-64
Download Eigen over HTTPS rather than plain HTTP
2 parents b2d5a4d + a51fea2 commit f522d9f

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

‎CMakeLists.txt‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,11 @@
138138
message(STATUS "Found Eigen3 version ${Eigen3_VERSION} in ${Eigen3_DIR}")
139139
else()
140140
message(STATUS "Attempt to install custom Eigen3 automatically...")
141-
FetchContent_Declare(Eigen3 URL http://github.com/codac-team/eigen/archive/refs/heads/eigen-5.0.zip)
141+
# Over HTTPS, not plain HTTP: the connections to port 80 of github.com timed
142+
# out now and then on the GitHub Actions runners, failing the whole job at
143+
# configuration time ("Failed to connect to github.com port 80"), and HTTPS
144+
# also guarantees that the archive comes from GitHub unaltered.
145+
FetchContent_Declare(Eigen3 URL https://github.com/codac-team/eigen/archive/refs/heads/eigen-5.0.zip)
142146
#FetchContent_Declare(Eigen3 URL ${CMAKE_CURRENT_SOURCE_DIR}/3rd/eigen-a0dc3994bd5d4e804dab58decb78c56a5af516ba.zip) # If needed to be self-contained...
143147
FetchContent_MakeAvailable(Eigen3)
144148
endif()

0 commit comments

Comments
 (0)