Skip to content

checkMaintainerInLFX needs some re-thinking #293

Description

@jeefy

maintainers.go:243 creates a bare &http.Client{} instead of using the validator's injected pv.client. This means:

  • No timeout configured (could hang indefinitely on a slow/unresponsive LFX API)
  • Can't be tested with httptest since the client isn't injectable
  • Currently broken anyway due to no long-lived LFX token (TBD)

Metadata

Metadata

Labels

needs-kindIndicates an issue or PR that is missing an issue type or kind (a kind/foo label)needs-triageIndicates an issue or PR that has not been triaged yet (has a 'triage/foo' label applied)

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions