Skip to content

feat(code): add plain variant to CodeHighlighted component - #802

Merged
mattrothenberg merged 8 commits into
cloudflare:mainfrom
invisal:feat/frameless-code-block
Sep 17, 2026
Merged

mattrothenberg merged 8 commits into
cloudflare:mainfrom
invisal:feat/frameless-code-block

Conversation

@invisal

@invisal invisal commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

This PR introduces a plain variant to the CodeHighlighted component, allowing frameless code blocks

Reviews

  • bonk has reviewed the change
  • automated review not possible because:

Tests

  • Tests included/updated
  • Automated tests not possible - manual testing has been completed as follows:
  • Additional testing not necessary because:

@pkg-pr-new

pkg-pr-new Bot commented Sep 14, 2026 •

Copy link
Copy Markdown
npm i https://pkg.pr.new/@cloudflare/kumo@802

commit: af049dd

@github-actions

github-actions Bot commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Docs Preview

View docs preview

Commit: af049dd

@github-actions

github-actions Bot commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

📐 Bundle Size

Consumer fixtures bundled against packages/kumo/dist (peers external, minified ESM).

Fixture Raw Gzip Brotli
Button (root) 174.6 KB 49.9 KB 43.1 KB
Button (components/button) 174.5 KB 49.9 KB 43.1 KB
Button + Dialog + Select (root) 299.5 KB 85.8 KB 71.9 KB
Button + Dialog + Select (component subpaths) 299.5 KB 85.9 KB 71.9 KB
Chart (root) 247.0 KB 71.1 KB 60.9 KB
Chart (components/chart) 246.9 KB 71.1 KB 60.9 KB
Badge (components/badge) 44.7 KB 11.7 KB 10.0 KB
Flow (components/flow) 208.9 KB 58.3 KB 50.5 KB
Button (primitives/button) 12.2 KB 4.4 KB 3.9 KB
Primitives barrel 635.8 KB 176.9 KB 139.3 KB
Code highlighting (code) 2.08 MB 468.0 KB 349.3 KB

npm tarball: 544 files, 1.49 MB packed, 6.95 MB unpacked.

⚠️ 23 flagged files in tarball (tests / raw scripts)
  • dist/blocks-source/resource-list/resource-list.test.tsx
  • scripts/component-registry/cache.ts
  • scripts/component-registry/discovery.ts
  • scripts/component-registry/example-cleanup.ts
  • scripts/component-registry/index.test.ts
  • scripts/component-registry/index.ts
  • scripts/component-registry/markdown-generator.ts
  • scripts/component-registry/metadata.ts
  • scripts/component-registry/props-filter.ts
  • scripts/component-registry/schema-generator.ts
  • scripts/component-registry/sub-components.ts
  • scripts/component-registry/types.ts
  • scripts/component-registry/utils.ts
  • scripts/component-registry/variant-parser.ts
  • scripts/css-build.ts
  • scripts/generate-globe-land-mask.mjs
  • scripts/generate-primitives.ts
  • scripts/theme-generator/config.ts
  • scripts/theme-generator/generate-css.test.ts
  • scripts/theme-generator/generate-css.ts
  • scripts/theme-generator/index.ts
  • scripts/theme-generator/migrate.ts
  • scripts/theme-generator/types.ts

Report-only: no size thresholds are enforced yet.

Commit: af049ddd

@github-actions

github-actions Bot commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor
Visual Regression Report — 27 changed, 18 unchanged

27 screenshot(s) with visual changes:

Button / Loading State

31 px (0.04%) changed

Before After Diff
Before After Diff

Button / Disabled State

0 px (0%) changed

Before After Diff
Before After Diff

Button / Title

848 px (0.96%) changed

Before After Diff
Before After Diff

Button / Link as Button

820 px (0.93%) changed

Before After Diff
Before After Diff

Button / Link with Tooltip

579 px (0.65%) changed

Before After Diff
Before After Diff

Dialog / Dialog With Actions

362 px (0.41%) changed

Before After Diff
Before After Diff

Dialog / Dialog Basic

319 px (0.36%) changed

Before After Diff
Before After Diff

Dialog / Dialog Sizes

3,084 px (3.48%) changed

Before After Diff
Before After Diff

Dialog / Dialog Alert

912 px (1.03%) changed

Before After Diff
Before After Diff

Dialog / Dialog Confirmation

1,820 px (2.06%) changed

Before After Diff
Before After Diff

Dialog / Dialog With Select

491 px (0.55%) changed

Before After Diff
Before After Diff

Dialog (Open)

0 px (0%) changed

Before After Diff
Before After Diff

Select / Select Sizes

362 px (0.22%) changed

Before After Diff
Before After Diff

Select / Select Placement

4,273 px (2.95%) changed

Before After Diff
Before After Diff

Select / Select Dynamic Placement

2,608 px (2.51%) changed

Before After Diff
Before After Diff

Select / Select Without Label

664 px (0.75%) changed

Before After Diff
Before After Diff

Select / Select With Description

1,688 px (1.62%) changed

Before After Diff
Before After Diff

Select / Select With Tooltip

657 px (0.74%) changed

Before After Diff
Before After Diff

Select / Select Custom Rendering

973 px (1.1%) changed

Before After Diff
Before After Diff

Select / Select Loading

2,375 px (1.35%) changed

Before After Diff
Before After Diff

Select / Select Multiple

1,563 px (1.76%) changed

Before After Diff
Before After Diff

Select / Select Complex

1,279 px (1.23%) changed

Before After Diff
Before After Diff

Select / Select Disabled Options

200 px (0.23%) changed

Before After Diff
Before After Diff

Select / Select Disabled Items

771 px (0.87%) changed

Before After Diff
Before After Diff

Select / Select Grouped

962 px (1.09%) changed

Before After Diff
Before After Diff

Select / Select Long List

1,517 px (1.46%) changed

Before After Diff
Before After Diff

Select (Open)

1,183 px (0%) changed

Before After Diff
Before After Diff
18 screenshot(s) unchanged
  • Button / Basic
  • Button / Variant: Primary
  • Button / Variant: Secondary
  • Button / Variant: Ghost
  • Button / Variant: Destructive
  • Button / Variant: Outline
  • Button / Variant: Secondary Destructive
  • Button / Sizes
  • Button / With Icon
  • Button / Icon Only
  • Button / Disabled Link
  • Dialog / Custom Max Width
  • Dialog / Dialog With Combobox
  • Dialog / Dialog With Dropdown
  • Select / Select Basic
  • Select / Select With Error
  • Select / Select Placeholder
  • Select / Select Grouped With Disabled

Generated by Kumo Visual Regression

@github-actions

github-actions Bot commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Visual contracts

Linux Chromium references exercised by the PR's visual-contracts job.

1 curated contract

truncating text trigger

truncating text trigger

@mattrothenberg
mattrothenberg merged commit 9c970e3 into cloudflare:main Sep 17, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants