From 1422bb656a88468aa3b05bd09943a58d75762be7 Mon Sep 17 00:00:00 2001 From: mehmetkr-31 Date: Thu, 10 Sep 2026 12:10:46 +0300 Subject: [PATCH] chore(evm-node): remove stale chain-spec FIXME MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `crates/evm-node/src/node.rs` carries: // FIXME use the ethereum chain spec temporary, we need to define Arc chain spec // original traits for ChainSpec in this file `Hardforks + EthereumHardforks + EthExecutorSpec` Arc's chain spec already exists and this file already uses it: `ArcChainSpec` is defined in `crates/execution-config/src/chainspec.rs` and node.rs binds `ChainSpec = ArcChainSpec` throughout. That was already true in the first public commit (a1235c0), where node.rs used `ArcChainSpec` 10 times — so the FIXME has been stale since it landed. The second line documented the upstream reth file's ChainSpec bounds and only made sense as a continuation of the FIXME, so it goes too. Comments only; no behaviour change. Co-Authored-By: Claude Opus 5 --- crates/evm-node/src/node.rs | 3 --- 1 file changed, 3 deletions(-) diff --git a/crates/evm-node/src/node.rs b/crates/evm-node/src/node.rs index b8ce9f4..cd5a3a0 100644 --- a/crates/evm-node/src/node.rs +++ b/crates/evm-node/src/node.rs @@ -79,9 +79,6 @@ use arc_execution_config::chainspec::ArcChainSpec; use arc_execution_payload::payload::ArcNetworkPayloadBuilderBuilder; use arc_execution_txpool::{ArcPoolBuilder, InvalidTxList, InvalidTxListConfig}; -// FIXME use the ethereum chain spec temporary, we need to define Arc chain spec -// original traits for ChainSpec in this file `Hardforks + EthereumHardforks + EthExecutorSpec` - use crate::rpc_middleware::{ ArcRpcLayer, ARC_RPC_MAX_BATCH_ENTRIES_DEFAULT, DEFAULT_TX_RELAY_TIMEOUT, };