Skip to content

Commit 1b6f281

Browse files
authored
Merge pull request #7 from chtnnh/fix/gh-actions-node24-bump
ci: bump Actions off Node 20 runtime (#6)
2 parents 50a06ce + 4f2520e commit 1b6f281

10 files changed

Lines changed: 21 additions & 15 deletions

File tree

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ jobs:
99
build:
1010
runs-on: ubuntu-latest
1111
steps:
12-
- uses: actions/checkout@v4
13-
- uses: actions/setup-node@v4
12+
- uses: actions/checkout@v5
13+
- uses: actions/setup-node@v5
1414
with:
1515
node-version: "22"
1616
cache: npm

.github/workflows/docs.yml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@ jobs:
2323
build:
2424
runs-on: ubuntu-latest
2525
steps:
26-
- uses: actions/checkout@v4
26+
- uses: actions/checkout@v5
2727

28-
- uses: actions/setup-node@v4
28+
- uses: actions/setup-node@v5
2929
with:
3030
node-version: "22"
3131
cache: npm
@@ -38,9 +38,11 @@ jobs:
3838
npm run build -w website
3939
4040
- name: Upload Pages artifact
41-
uses: actions/upload-pages-artifact@v3
41+
uses: actions/upload-pages-artifact@v5
4242
with:
4343
path: website/build
44+
# v4+ excludes dotfiles by default; Docusaurus needs .nojekyll.
45+
include-hidden-files: true
4446

4547
deploy:
4648
needs: build
@@ -50,4 +52,4 @@ jobs:
5052
url: ${{ steps.deployment.outputs.page_url }}
5153
steps:
5254
- id: deployment
53-
uses: actions/deploy-pages@v4
55+
uses: actions/deploy-pages@v5

.github/workflows/know-code.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,15 @@ jobs:
1313
verify:
1414
runs-on: ubuntu-latest
1515
steps:
16-
- uses: actions/checkout@v4
16+
- uses: actions/checkout@v5
1717
with:
1818
fetch-depth: 0
1919
# Default pull_request checkout is a merge commit (no trailers).
2020
# Verify must run on the PR tip that carries Know-Code-Verified.
2121
# On push, head.sha is empty so this is github.sha (the new tip).
2222
ref: ${{ github.event.pull_request.head.sha || github.sha }}
2323

24-
- uses: actions/setup-node@v4
24+
- uses: actions/setup-node@v5
2525
with:
2626
node-version: "22"
2727
cache: npm

.github/workflows/release.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,12 @@ jobs:
2020
runs-on: ubuntu-latest
2121
environment: npm-release
2222
steps:
23-
- uses: actions/checkout@v4
23+
- uses: actions/checkout@v5
2424

2525
# Node 24 → npm ≥ 11.5.1 (required for trusted publishing).
2626
# Do NOT set registry-url: setup-node would inject a dummy NODE_AUTH_TOKEN
2727
# that prevents the OIDC exchange (ENEEDAUTH).
28-
- uses: actions/setup-node@v4
28+
- uses: actions/setup-node@v5
2929
with:
3030
node-version: "24"
3131
package-manager-cache: false

.github/workflows/umami-proxy.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
runs-on: ubuntu-latest
2323
timeout-minutes: 10
2424
steps:
25-
- uses: actions/checkout@v4
25+
- uses: actions/checkout@v5
2626

2727
- name: Deploy Worker
2828
uses: cloudflare/wrangler-action@v4

action/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ on:
1616

1717
# ...
1818

19-
- uses: actions/checkout@v4
19+
- uses: actions/checkout@v5
2020
with:
2121
fetch-depth: 0
2222
ref: ${{ github.event.pull_request.head.sha || github.sha }}

action/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ runs:
3838
using: composite
3939
steps:
4040
- name: Setup Node
41-
uses: actions/setup-node@v4
41+
uses: actions/setup-node@v5
4242
with:
4343
node-version: "22"
4444

packages/cli/src/commands-core.test.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -256,6 +256,7 @@ describe("commands: config / init / quiz / doctor / reset / ship", () => {
256256
const yml = consumerWorkflowYaml("develop");
257257
assert.match(yml, /base-branch: develop/);
258258
assert.match(yml, /chtnnh\/know-code\/action@v0\.3\.0/);
259+
assert.match(yml, /actions\/checkout@v5/);
259260
assert.match(yml, /pull_request:/);
260261
assert.match(yml, /push:/);
261262
assert.match(yml, /branches:\n {6}- develop/);
@@ -274,6 +275,8 @@ describe("commands: config / init / quiz / doctor / reset / ship", () => {
274275
join(repoRoot, ".github", "workflows", "know-code.yml"),
275276
"utf8",
276277
);
278+
assert.match(workflow, /actions\/checkout@v5/);
279+
assert.match(workflow, /actions\/setup-node@v5/);
277280
assert.match(workflow, /push:/);
278281
assert.match(workflow, /branches: \[main\]/);
279282
assert.match(workflow, /verify --from/);
@@ -283,6 +286,7 @@ describe("commands: config / init / quiz / doctor / reset / ship", () => {
283286
assert.match(workflow, /else\n know-code verify\n/);
284287

285288
const action = readFileSync(join(repoRoot, "action", "action.yml"), "utf8");
289+
assert.match(action, /actions\/setup-node@v5/);
286290
assert.match(action, /^ {2}from:/m);
287291
assert.match(action, /zero before SHA/);
288292
assert.match(action, /--from \$FROM/);

packages/cli/src/commands/init.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
verify:
2727
runs-on: ubuntu-latest
2828
steps:
29-
- uses: actions/checkout@v4
29+
- uses: actions/checkout@v5
3030
with:
3131
fetch-depth: 0
3232
ref: \${{ github.event.pull_request.head.sha || github.sha }}

website/docs/ci.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
verify:
2727
runs-on: ubuntu-latest
2828
steps:
29-
- uses: actions/checkout@v4
29+
- uses: actions/checkout@v5
3030
with:
3131
fetch-depth: 0
3232
ref: ${{ github.event.pull_request.head.sha || github.sha }}

0 commit comments

Comments
 (0)