-
Notifications
You must be signed in to change notification settings - Fork 9
Open
Description
Hi! Thanks again for the library. When trying to use the oath flow, I noticed a few bugs that I had to patch locally. I can upstream them here if you want, but its a bit of a refactor. They're listed below.
- The
OauthApiin theAuthenticatedXrpcBlueskyApishares the sameHttpClientas theAuthPlugin. This causes circular loops for oauth flows whenuse_dpop_nonceis present in response headers. - The
OauthApicannot parse theAtpExceptionjson response bc it's private json requiresexplicitNulls. It should probably inherit content negotiation from theHttpClientpassed to it, and not set its own. - The error response header when an oauth token lapses seems to be
invalid_tokennotExpiredToken.
I ended up going with an explicit SessionManager to separate a few concerns.
tsal
Metadata
Metadata
Assignees
Labels
No labels