Mongoose v6 ObjectId deepEqual always true

[spaiz]

Hi. We did pay attention in our tests that we cannot rely anymore on deep.equal when comparing objects with ObjectId() or even ObjectIds itself.

Env: node v16
Mongoose version: v5 vs v6

For the mongoose v5 tests work as expected.

{
  "dependencies": {
    "chai": "^4.3.6",
    "mocha": "^10.0.0",
    "mongoose": "^5.0.0"
  }
}

For mongoose v6 tests are passing when they should fail.

{
  "dependencies": {
    "chai": "^4.3.6",
    "mocha": "^10.0.0",
    "mongoose": "^6.0.0"
  }
}

I did prepare a repo for reproducing the issue: https://github.com/spaiz/objectId_tests

[spaiz]

I assume this PR should fix it :/

chaijs/deep-eql#86

[leyb-guesty]

hi
any news on this?

[qstrahl]

I believe this issue has been fixed, at least as of the latest version in the 7.x branch - possibly earlier. @spaiz @leyb-guesty can you confirm?