Skip to content

DINC0774469 : Link not getting created in nested entities #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rishikunnath2747 merged 4 commits into from
Feb 3, 2026
Merged

DINC0774469 : Link not getting created in nested entities #417

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
95e5aa7
fix
rishikunnath2747 Jan 30, 2026
fc0e17e
updating pom for testing
rishikunnath2747 Jan 30, 2026
7c3efc9
ut fix
rishikunnath2747 Jan 30, 2026
aa10909
Update project revision to 1.7.1-SNAPSHOT
rishikunnath2747 Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions sdm/src/main/java/com/sap/cds/sdm/service/handler/SDMServiceGenericHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
package com.sap.cds.sdm.service.handler;

import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.sap.cds.Result;
import com.sap.cds.Row;
import com.sap.cds.feature.attachments.service.AttachmentService;
import com.sap.cds.ql.Insert;
import com.sap.cds.ql.Select;
import com.sap.cds.ql.Update;
Expand Down Expand Up @@ -420,18 +417,23 @@ private void createLink(EventContext context) throws IOException {
? SDMUtils.getUpIdKey(attachmentDraftEntity.get())
: "up__ID";
CqnSelect select = (CqnSelect) context.get("cqn");
// Get parent entity to extract its key names dynamically

// Derive the parent entity name from the target qualified name
// Target is like "AdminService.Chapters.attachments", parent is "AdminService.Chapters"
String targetQualifiedName = context.getTarget().getQualifiedName();
String parentEntityName = null;
ObjectMapper mapper = new ObjectMapper();
JsonNode root = mapper.readTree(select.toString());
JsonNode refArray = root.path("SELECT").path("from").path("ref");
if (refArray.isArray() && refArray.size() >= 2) {
JsonNode parentNode = refArray.get(refArray.size() - 2);
parentEntityName = parentNode.path("id").asText();
int lastDotIndex = targetQualifiedName.lastIndexOf('.');
if (lastDotIndex > 0) {
parentEntityName = targetQualifiedName.substring(0, lastDotIndex);
}

Optional<CdsEntity> parentEntity =
parentEntityName != null ? cdsModel.findEntity(parentEntityName) : Optional.empty();

if (parentEntity.isEmpty()) {
throw new ServiceException(SDMUtils.getErrorMessage("ENTITY_PROCESSING_ERROR_LINK"));
}

String upID = SDMUtils.fetchUPIDFromCQN(select, parentEntity.get());
String filenameInRequest = context.get("name").toString();

Expand Down Expand Up @@ -463,8 +465,7 @@ private void createLink(EventContext context) throws IOException {
createResult =
documentService.createDocument(cmisDocument, sdmCredentials, isSystemUser, null);
} catch (Exception e) {
throw new ServiceException(
SDMErrorMessages.getGenericError(AttachmentService.EVENT_CREATE_ATTACHMENT), e);
throw new ServiceException(SDMUtils.getErrorMessage("ENTITY_PROCESSING_ERROR_LINK"), e);
}
handleCreateLinkResult(cmisDocument, createResult, context, upID, upIdKey);
}
Expand Down
Loading