-
Notifications
You must be signed in to change notification settings - Fork 8
Open
Labels
Hacker News Appgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed
Description
As marked in https://github.com/briskml/brisk/blob/master/examples/hacker-news/app/Story.re#L82, we'll need to transform incoming html.
<p> tags are not rendered with proper margin/padding by Cocoa in NSTextView by default, and instead of manually changing document attributes on ObjC bindings side, simply pre-processing html text and replacing paragraphs by newline characters seems more preferable.
We already use markup.ml, so it shouldn't be hard to do the adjustments. The relevant part to look at is http://aantron.github.io/markup.ml/#VALtree
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Hacker News Appgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed