workflow params

Author: cpinn

.github/workflows/js.yaml

@@ -16,14 +16,17 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu-latest]
-        node-version: [22]
+        os: [ubuntu-latest, windows-latest]
+        node-version: [20, 22]
 
     env:
       ANTHROPIC_API_KEY: ${{ secrets.ANTHROPIC_API_KEY}}
       OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY}}
       GEMINI_API_KEY: ${{ secrets.GEMINI_API_KEY}}
 
+    outputs:
+      artifact-name: ${{ steps.artifact.outputs.name }}
+
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
@@ -32,20 +35,35 @@ jobs:
           registry-url: "https://registry.npmjs.org"
       - uses: pnpm/action-setup@v4
       - name: "verify ci"
+        shell: bash
+        run: |
+          npm install
+          npm run build
+
+      - name: Determine artifact name
+        id: artifact
+        env:
+          ARTIFACT_NAME: javascript-sdk-dev-${{ github.run_id }}
         run: |
-          pnpm install
-          pnpm run build
+          echo "Artifact: $ARTIFACT_NAME"
+          echo "name=$ARTIFACT_NAME" >> "$GITHUB_OUTPUT"
       - name: Upload build artifacts
-        if: matrix.node-version == '22' && matrix.os == 'ubuntu-latest'
         uses: actions/upload-artifact@v4
         with:
-          name: javascript-sdk-dev-${{ github.run_id }}-${{ matrix.node-version }}-dist
+          name: ${{ steps.artifact.outputs.name }}-${{ matrix.os }}-${{ matrix.node-version }}-dist
           path: js/dist/
           retention-days: 1
 
   integration-tests:
     needs: build
     runs-on: ubuntu-latest
+    
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-latest, windows-latest]
+        node-version: [20, 22]
+
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
@@ -56,55 +74,72 @@ jobs:
       - name: Backup original NodeSDK package.json
         working-directory: js/examples/otel
         run: cp package.json package.json.bak
-
-      - name: Determine artifact name
+      
+      - name: artifact name
         id: artifact
-        run: echo "ARTIFACT_NAME=javascript-sdk-dev-${{ github.run_id }}-22-dist" >> $GITHUB_ENV
+        run: |
+          echo "Artifact: ${{ needs.build.outputs.artifact-name }}-${{ matrix.os }}-${{ matrix.node-version }}-dist"
+          echo "name=${{ needs.build.outputs.artifact-name }}-${{ matrix.os }}-${{ matrix.node-version }}-dist" >> "$GITHUB_OUTPUT"
 
       - name: Download javascript dist artifact
         uses: actions/download-artifact@v4
         with:
           name: ${{ steps.artifact.outputs.name }}
           path: js/artifacts
-          run-id: ${{ inputs.build_run_id }}
+          run-id: ${{ github.run_id }}
           github-token: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Setup Node.js
         uses: actions/setup-node@v4
         with:
           node-version: 22
 
+      - name: Temporarily point braintrust dependency to local build
+        working-directory: js/examples/otel
+        run: |
+          # Modify package.json to point 'braintrust' to local artifact
+          cat "file:../../artifacts/${{ steps.artifact.outputs.name }}"
+          ls -la ../../artifacts/${{ steps.artifact.outputs.name }}
+          jq --arg path "file:../../artifacts/${{ steps.artifact.outputs.name }}" '.dependencies.braintrust = $path' package.json > package.temp.json
+          mv package.temp.json package.json
+          cat package.json
+
       - name: Install example dependencies
         working-directory: js/examples/otel
-        run: npm install
+        run: npm install --force
+
+      - name: Run CJS check
+        working-directory: scripts
+        run: ./verify_cjs.sh
 
       - name: Run NodeSDK as CJS example
         working-directory: js/examples/otel
         env:
           BRAINTRUST_OTEL_COMPAT: false
           BRAINTRUST_API_KEY: ${{ secrets.BRAINTRUST_API_KEY }}
-          NODE_PATH: ../../artifacts
         run: |
-          node -e "console.log('CJS mode:', typeof require !== 'undefined')"
           npm start
 
       - name: Enable ESM for this run
         working-directory: js/examples/otel
         run: |
           jq '. + {"type":"module"}' package.json > package.temp.json
           mv package.temp.json package.json
+          cat package.json
+
+      - name: Run ESM check
+        working-directory: scripts
+        run: ./verify_esm.sh
 
       - name: Run NodeSDK as ESM example
         working-directory: js/examples/otel
         env:
           BRAINTRUST_OTEL_COMPAT: false
           BRAINTRUST_API_KEY: ${{ secrets.BRAINTRUST_API_KEY }}
-          NODE_PATH: ../../artifacts
         run: |
-          node -e "console.log('ESM mode:', typeof import.meta.url === 'string')"
           npm start
 
       - name: Restore original package.json
         if: always()
         working-directory: js/examples/otel
-        run: mv package.json.bak package.json
+        run: mv package.json.bak package.json

scripts/verify_cjs.sh

@@ -0,0 +1,9 @@
+#!/usr/bin/env bash
+node -e '
+if (typeof require === "undefined") {
+  console.error("Error: Not running in CommonJS");
+  process.exit(1);
+} else {
+  console.log("Running in CommonJS");
+}
+'

scripts/verify_esm.sh

@@ -0,0 +1,9 @@
+#!/usr/bin/env bash
+node -e '
+if (typeof import.meta.url !== "string") {
+  console.error("Error: Not running in ESM");
+  process.exit(1);
+} else {
+  console.log("Running in ESM");
+}
+'