Logout does not logout from Drupal IdP

[rvbelzen]

For some reason, which remains a mystery to me, the function getUser() of the class External never is able to determine the user ( if (!$user->isAnonymous()) is FALSE). This prevents the user from being logged out from the IdP.

A work-around that I use is to destroy the session in the function logout():

  public function logout(&$state) {
    assert('is_array($state)');

    if ($this->bootstrap()->getUser()) {
      // We may not have a session started, but SessionManager will throw
      // an error if it tries to destroy an uninitialized session.
      $this->container->get('session_manager')->start();
      user_logout();
    }
    else {
      $request = \Drupal::request();
      $request->getSession()->clear();
    }
  }

In the request the proper SESSION cookie for the logged in user was available, but still the user could not be found. Clearing the session in that case does the job.

drupal/core 8.4.2
drupal/saml_idp 1.x-dev
simplesamlphp/saml2 v1.9.1
simplesamlphp/simplesamlphp v1.14.17

[ryaneastabrook]

We're also running into this issue.

[bradjones1]

Unfortunately my workload at the moment prohibits me from being able to spend much pro bono time on this module; if you'd like to discuss sponsored development for saml_idp, please send me an e-mail (in my profile.) I would also welcome discussion and a PR here, of course.

[andsigno82]

@rvbelzen you saved my head with this workaround. I was going literally crazy with this issue and was about to break everything to debug it...