WIP pr comments

Author: imRohan

lib/bls/core.rb

@@ -17,7 +17,7 @@
 require_relative "core/resources/api_error"
 require_relative "core/authorization/bearer"
 require_relative "core/resources/object"
-require_relative "core/resources/objectv2"
+require_relative "core/resources/object_v2"
 require_relative "core/resources/allergen"
 require_relative "core/resources/dietary_tag"
 require_relative "core/resources/ingredient"
@@ -30,6 +30,7 @@
 require_relative "core/resources/menu_item"
 require_relative "core/serializers/menu_item_serializer"
 require_relative "core/resources/product"
+require_relative "core/resources/product_factory"
 require_relative "core/resources/recipient"
 require_relative "core/serializers/recipient_serializer"
 require_relative "core/version"

lib/bls/core/resources/objectv2.rb lib/bls/core/resources/object_v2.rblib/bls/core/resources/objectv2.rb renamed to lib/bls/core/resources/object_v2.rb

@@ -3,27 +3,13 @@
 module Bls
   module Core
     class Product < Bls::Core::ObjectV2
-      def initialize(args = {})
-        super
-      end
-
       def object_name
         "products"
       end
 
       def self.build_from_response(data)
-        product = build(data)
-        product.ingredients = Ingredient.build_from_array(data[:ingredients])
-        as_packaged = NutritionFact.
-                      build_from_array(data[:nutrition_facts][:as_packaged])
-        as_cooked = NutritionFact.
-                    build_from_array(data[:nutrition_facts].
-                                     fetch(:as_cooked, []))
-        product.allergens = Allergen.build_from_array(data[:allergens])
-        product.dietary_tags = DietaryTag.build_from_array(data[:dietary_tags])
-        product.nutrition_facts = { as_packaged: as_packaged,
-                                    as_cooked: as_cooked }
-        product
+        factory = ProductFactory.new(data)
+        factory.create
       end
     end
   end

lib/bls/core/resources/product.rb

@@ -0,0 +1,45 @@
+# frozen_string_literal: true
+
+module Bls
+  module Core
+    class ProductFactory
+      attr_accessor :response
+
+      def initialize(response)
+        @response = response
+      end
+
+      def create
+        product = Product.build(response)
+        product.ingredients = ingredients
+        product.allergens = allergens
+        product.dietary_tags = dietary_tags
+        product.nutrition_facts = nutrition_facts
+        product
+      end
+
+      protected
+
+      def ingredients
+        Ingredient.build_from_array(response[:ingredients])
+      end
+
+      def allergens
+        Allergen.build_from_array(response[:allergens])
+      end
+
+      def dietary_tags
+        DietaryTag.build_from_array(response[:dietary_tags])
+      end
+
+      def nutrition_facts
+        as_packaged = NutritionFact.
+                      build_from_array(response[:nutrition_facts][:as_packaged])
+        as_cooked = NutritionFact.
+                    build_from_array(response[:nutrition_facts].
+                                     fetch(:as_cooked, []))
+        { as_packaged: as_packaged, as_cooked: as_cooked }
+      end
+    end
+  end
+end

lib/bls/core/resources/product_factory.rb

@@ -0,0 +1,46 @@
+# frozen_string_literal: true
+
+RSpec.describe Bls::Core::ProductFactory do
+  describe "#create" do
+    it "assigns the ingredients to the Product" do
+      response = build_product_response
+      ingredient = Bls::Core::Ingredient.build(response[:ingredients])
+      factory = Bls::Core::ProductFactory.new(response)
+
+      result = factory.create
+
+      expect(result.ingredients).to match_array(ingredient)
+    end
+
+    it "assigns the allergens to the Product" do
+      response = build_product_response
+      allergen = Bls::Core::Allergen.build_from_array(response[:allergens])
+      factory = Bls::Core::ProductFactory.new(response)
+
+      result = factory.create
+
+      expect(result.allergens).to match_array(allergen)
+    end
+
+    it "assigns the dietary tags to the Product" do
+      response = build_product_response
+      dietary_tags = Bls::Core::Allergen.
+                     build_from_array(response[:dietary_tags])
+      factory = Bls::Core::ProductFactory.new(response)
+
+      result = factory.create
+
+      expect(result.dietary_tags).to match_array(dietary_tags)
+    end
+
+    it "assigns the nutrition facts to the Product" do
+      response = build_product_response
+      factory = Bls::Core::ProductFactory.new(response)
+      product = factory.create
+
+      result = product.nutrition_facts
+
+      expect(result.keys).to match_array([:as_packaged, :as_cooked])
+    end
+  end
+end

spec/core/resources/product_factory_spec.rb

@@ -13,18 +13,18 @@
 
       expect(result.code).to eq(product_id)
     end
+  end
 
-    it "returns packaged and cooked nutrition facts" do
-      body = build_product_response
-      response = build_response(body: body)
-      stub_api_v2_authentication
-      stub_api_response response: response
+  describe ".build_from_response" do
+    it "creates a product using the product factory" do
+      response = build_product_response
+      factory = Bls::Core::ProductFactory.new(response)
+      allow(Bls::Core::ProductFactory).to receive(:new).and_return(factory)
+      allow(factory).to receive(:create)
 
-      result = Bls::Core::Product.retrieve("TEST123")
+      Bls::Core::Product.build_from_response(response)
 
-      expect(result.nutrition_facts.keys).to match_array(
-        [:as_packaged, :as_cooked]
-      )
+      expect(factory).to have_received(:create).once
     end
   end
 end

spec/core/resources/product_spec.rb

@@ -43,4 +43,5 @@
   "dietary_tags": [
     "PESCATARIAN"
   ]
-}
+}
+