You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit c1fc17e
Browse filesBrowse the repository at this point in the historyBrowse files
Close out final-review findings for the /ps and /stop background-process controls
Adds the spec-mandated interactive-only regression test for /ps and /stop to
the parametrized gating suite, then works through the remaining polish items
from the whole-branch review: killProcessGroup's four near-identical
platform-fallback blocks collapse into a single attemptKill helper (with the
already-dead fast-path preserved so shutdown timing is unchanged); a shared
formatBackgroundProcessEntry formatter replaces the duplicated per-command
rendering in ps.ts and stop.ts so the ambiguous-target listing in /stop now
matches /ps exactly, as the design spec requires; the killProcessGroup
fallback test no longer leaks a live child process on assertion failure;
and BackgroundProcessRegistry.stop() carries a comment documenting the
narrow, inherent pid-reuse race, which is accepted rather than fixed since
it can't be closed portably. Rounds out coverage with an empty-registry
killAll() test, a /ps uptime-format assertion, and /stop boundary tests for
"0", "-1", "1.5", and an empty-string argument.
Co-authored-by: Autohand Evolve <code-noreply@autohand.ai>
0 commit comments